From: tytso@mit.edu
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Jiaying Zhang <jiayingz@google.com>
Subject: Re: [PATCH V2] Add flag to files with blocks intentionally past EOF
Date: Wed, 24 Feb 2010 11:26:21 -0500 [thread overview]
Message-ID: <20100224162621.GD5166@thunk.org> (raw)
In-Reply-To: <4B58963E.4080007@redhat.com>
On Thu, Jan 21, 2010 at 12:00:30PM -0600, Eric Sandeen wrote:
> From: Jiaying Zhang <jiayingz@google.com>
>
> fallocate() may potentially instantiate blocks past EOF, depending
> on the flags used when it is called.
>
> e2fsck currently has a test for blocks past i_size, and it
> sometimes trips up - noticeably on xfstests 013 which runs fsstress.
>
> This patch from Jiayang does fix it up - it (along with
> e2fsprogs updates and other patches recently from Aneesh) has
> survived many fsstress runs in a row.
>
>
> (Eric Sandeen: removed ioctl interface and minor cleanups)
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to the maint branch, although I added back the ability to
truncate the fallocated blocks via chattr.
- Ted
prev parent reply other threads:[~2010-02-24 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 21:45 [PATCH] Add flag to files with blocks intentionally past EOF Eric Sandeen
2010-01-20 0:46 ` Mingming
2010-01-20 3:58 ` Eric Sandeen
2010-01-20 8:37 ` Andreas Dilger
2010-01-20 9:15 ` Aneesh Kumar K. V
2010-01-20 9:03 ` Aneesh Kumar K. V
2010-01-22 0:32 ` Andreas Dilger
2010-01-22 17:40 ` Eric Sandeen
2010-01-21 18:00 ` [PATCH V2] " Eric Sandeen
2010-01-21 20:32 ` Jiaying Zhang
2010-02-24 16:26 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224162621.GD5166@thunk.org \
--to=tytso@mit.edu \
--cc=jiayingz@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).