From: tytso@mit.edu
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: quota_write cross block boundary behaviour
Date: Tue, 2 Mar 2010 08:15:32 -0500 [thread overview]
Message-ID: <20100302131532.GF6077@thunk.org> (raw)
In-Reply-To: <878wab6p3s.fsf@openvz.org>
On Tue, Mar 02, 2010 at 12:37:43PM +0300, Dmitry Monakhov wrote:
> Jan Kara <jack@suse.cz> writes:
>
> > On Tue 16-02-10 19:33:41, Dmitry Monakhov wrote:
> >> We always assume what dquot update result in changes in one data block
> >> But ext4_quota_write() function may handle cross block boundary writes
> >> In fact if this ever happen it will result in incorrect journal credits
> >> reservation. And later bug_on triggering. As soon this never happen the
> >> boundary cross loop is NOOP. In order to make things straight
> >> let's remove this loop and assert cross boundary condition.
> >>
> >> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> > Yeah, originally I thought it might be useful to support a possibility of
> > multiblock writes but in the end we never needed it and currently e.g. OCFS2
> > would already BUG on that so yes, this is a good simplification.
> > Acked-by: Jan Kara <jack@suse.cz>
> >
> > I've merged the ext3 version of the patch into my tree. Ted, will you
> > merge this ext4 cleanup please?
> Ted please take a look at the patch.
Sorry, I had lost track of this patch. I've added it to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2010-03-02 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 16:33 [PATCH 1/2] ext4: quota_write cross block boundary behaviour Dmitry Monakhov
2010-02-16 16:33 ` [PATCH 2/2] ext3: " Dmitry Monakhov
2010-02-16 18:46 ` [PATCH 1/2] ext4: " Jan Kara
[not found] ` <878wab6p3s.fsf@openvz.org>
2010-03-02 13:15 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302131532.GF6077@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).