* [PATCH] [RESEND] ext4: Release page references acquired in ext4_da_block_invalidatepages
@ 2010-03-03 13:54 Jan Kara
2010-03-04 4:51 ` tytso
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kara @ 2010-03-03 13:54 UTC (permalink / raw)
To: tytso; +Cc: linux-ext4, Jan Kara
We forget to release page references we acquire in
ext4_da_block_invalidatepages. Luckily, this function gets called only if we
are not able to allocate blocks for delay-allocated data so that function
should better never be called.
Also cleanup handling of index variable.
Reported-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/inode.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index c818972..1680007 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2127,17 +2127,16 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd,
break;
for (i = 0; i < nr_pages; i++) {
struct page *page = pvec.pages[i];
- index = page->index;
- if (index > end)
+ if (page->index > end)
break;
- index++;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [RESEND] ext4: Release page references acquired in ext4_da_block_invalidatepages
2010-03-03 13:54 [PATCH] [RESEND] ext4: Release page references acquired in ext4_da_block_invalidatepages Jan Kara
@ 2010-03-04 4:51 ` tytso
0 siblings, 0 replies; 2+ messages in thread
From: tytso @ 2010-03-04 4:51 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4
On Wed, Mar 03, 2010 at 02:54:07PM +0100, Jan Kara wrote:
> We forget to release page references we acquire in
> ext4_da_block_invalidatepages. Luckily, this function gets called only if we
> are not able to allocate blocks for delay-allocated data so that function
> should better never be called.
>
> Also cleanup handling of index variable.
>
> Reported-by: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Added to the ext4 patch queue, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-04 4:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-03 13:54 [PATCH] [RESEND] ext4: Release page references acquired in ext4_da_block_invalidatepages Jan Kara
2010-03-04 4:51 ` tytso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).