From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/5] quota: Implement project id support for generic quota
Date: Thu, 11 Mar 2010 07:03:34 -0500 [thread overview]
Message-ID: <20100311120334.GB4706@infradead.org> (raw)
In-Reply-To: <1267727677-11956-3-git-send-email-dmonakhov@openvz.org>
On Thu, Mar 04, 2010 at 09:34:34PM +0300, Dmitry Monakhov wrote:
> case GRPQUOTA:
> return in_group_p(dquot->dq_id);
> + case PRJQUOTA:
> + /* XXX: Currently there is no way to understand
> + which project_id this task belonges to, So print
> + a warn message unconditionally. -dmon */
> + return 1;
Note that this is different from the XFS behaviour, which neve warns
for project quota. In fact project quota in XFS traditionally doesn't
even return EDQUOT but ENOSPC instead, as it's not a traditional quota
mechanism but filesystem containerization.
Otherwise the patch looks good except for the ifdef mess already comment
on in the previous patch.
next prev parent reply other threads:[~2010-03-11 12:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 18:34 [PATCH 0/5] RFC: introduce extended inode owner identifier v5 Dmitry Monakhov
2010-03-04 18:34 ` [PATCH 1/5] vfs: Add additional owner identifier Dmitry Monakhov
2010-03-04 18:34 ` [PATCH 2/5] quota: Implement project id support for generic quota Dmitry Monakhov
2010-03-04 18:34 ` [PATCH 3/5] ext4: Implement project ID support for ext4 filesystem Dmitry Monakhov
2010-03-04 18:34 ` [PATCH 4/5] ext4: add isolated project support Dmitry Monakhov
2010-03-04 18:34 ` [PATCH 5/5] ext4: add project quota support Dmitry Monakhov
2010-03-04 20:07 ` [PATCH 4/5] ext4: add isolated project support Jan Kara
2010-03-04 20:34 ` Dmitry Monakhov
2010-03-11 12:07 ` Christoph Hellwig
2010-03-11 12:06 ` [PATCH 3/5] ext4: Implement project ID support for ext4 filesystem Christoph Hellwig
2010-03-11 13:30 ` Dmitry Monakhov
2010-03-11 19:54 ` Andreas Dilger
2010-03-11 22:01 ` tytso
2010-03-12 9:32 ` Dmitry Monakhov
2010-03-12 20:07 ` J. Bruce Fields
2010-03-11 12:03 ` Christoph Hellwig [this message]
2010-03-11 13:17 ` [PATCH 2/5] quota: Implement project id support for generic quota Dmitry Monakhov
2010-03-11 12:01 ` [PATCH 1/5] vfs: Add additional owner identifier Christoph Hellwig
2010-03-11 13:11 ` Dmitry Monakhov
2010-03-11 18:51 ` J. Bruce Fields
2010-03-11 19:40 ` Andreas Dilger
2010-03-12 8:47 ` Dmitry Monakhov
-- strict thread matches above, loose matches on Subject: below --
2010-03-18 14:02 [PATCH 0/5] RFC: introduce extended inode owner identifier v6 Dmitry Monakhov
2010-03-18 14:02 ` [PATCH 1/5] vfs: Add additional owner identifier Dmitry Monakhov
2010-03-18 14:02 ` [PATCH 2/5] quota: Implement project id support for generic quota Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311120334.GB4706@infradead.org \
--to=hch@infradead.org \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).