From: tytso@mit.edu
To: Anon Sricharoenchai <anon.hui@gmail.com>, 564084@bugs.debian.org
Cc: control@bugs.debian.org, linux-ext4@vger.kernel.org
Subject: Re: Bug#564084: debugfs: logdump -b<block> show incorrect allocation status in block bitmap
Date: Sun, 14 Mar 2010 19:02:30 -0400 [thread overview]
Message-ID: <20100314230230.GB5340@thunk.org> (raw)
In-Reply-To: <5914604b1001070757x7574f111qd578f499f9f7cab8@mail.gmail.com>
tags 564084 +pending
thanks
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564084
On Thu, Jan 07, 2010 at 10:57:25PM +0700, Anon Sricharoenchai wrote:
>
> *** Please type your report below this line ***
> "logdump -b<block>" command in debugfs show incorrect allocation status
> in block bitmap
Thanks for reporting this bug. I believe a much simpler fix for this
problem is:
diff --git a/debugfs/logdump.c b/debugfs/logdump.c
index 9a7108a..9364ce4 100644
--- a/debugfs/logdump.c
+++ b/debugfs/logdump.c
@@ -619,7 +619,7 @@ static void dump_metadata_block(FILE *out_file, struct journal_source *source,
int offset;
super = current_fs->super;
- offset = ((fs_blocknr - super->s_first_data_block) %
+ offset = ((block_to_dump - super->s_first_data_block) %
super->s_blocks_per_group);
fprintf(out_file, " (block bitmap for block %u: "
- Ted
parent reply other threads:[~2010-03-14 23:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <5914604b1001070757x7574f111qd578f499f9f7cab8@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314230230.GB5340@thunk.org \
--to=tytso@mit.edu \
--cc=564084@bugs.debian.org \
--cc=anon.hui@gmail.com \
--cc=control@bugs.debian.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).