linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Bug#564084: debugfs: logdump -b<block> show incorrect allocation status in block  bitmap
       [not found] <5914604b1001070757x7574f111qd578f499f9f7cab8@mail.gmail.com>
@ 2010-03-14 23:02 ` tytso
  0 siblings, 0 replies; only message in thread
From: tytso @ 2010-03-14 23:02 UTC (permalink / raw)
  To: Anon Sricharoenchai, 564084; +Cc: control, linux-ext4

tags 564084 +pending
thanks

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=564084

On Thu, Jan 07, 2010 at 10:57:25PM +0700, Anon Sricharoenchai wrote:
> 
> *** Please type your report below this line ***
> "logdump -b<block>" command in debugfs show incorrect allocation status
> in block bitmap

Thanks for reporting this bug.  I believe a much simpler fix for this
problem is:

diff --git a/debugfs/logdump.c b/debugfs/logdump.c
index 9a7108a..9364ce4 100644
--- a/debugfs/logdump.c
+++ b/debugfs/logdump.c
@@ -619,7 +619,7 @@ static void dump_metadata_block(FILE *out_file, struct journal_source *source,
 		int offset;
 
 		super = current_fs->super;
-		offset = ((fs_blocknr - super->s_first_data_block) %
+		offset = ((block_to_dump - super->s_first_data_block) %
 			  super->s_blocks_per_group);
 
 		fprintf(out_file, "    (block bitmap for block %u: "

				       	      	     - Ted

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-14 23:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <5914604b1001070757x7574f111qd578f499f9f7cab8@mail.gmail.com>
2010-03-14 23:02 ` Bug#564084: debugfs: logdump -b<block> show incorrect allocation status in block bitmap tytso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).