linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c
@ 2010-03-17 10:12 Steven Liu
  2010-03-22  0:20 ` tytso
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Liu @ 2010-03-17 10:12 UTC (permalink / raw)
  To: linux-ext4; +Cc: tytso, adilger, linux-kernel

fix a code style in fs/ext4/move_extent.c

Signed-off-by: LiuQi <lingjiujianke@gmail.com>
---
 fs/ext4/move_extent.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index aa5fe28..b399358 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -481,6 +481,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
 	int depth = ext_depth(orig_inode);
 	int ret;

+	start_ext.ee_block = end_ext.ee_block = 0;
 	o_start = o_end = oext = orig_path[depth].p_ext;
 	oext_alen = ext4_ext_get_actual_len(oext);
 	start_ext.ee_len = end_ext.ee_len = 0;
-- 
1.6.0.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c
  2010-03-17 10:12 [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c Steven Liu
@ 2010-03-22  0:20 ` tytso
  0 siblings, 0 replies; 2+ messages in thread
From: tytso @ 2010-03-22  0:20 UTC (permalink / raw)
  To: Steven Liu; +Cc: linux-ext4, adilger, Stefan Richter, linux-kernel

On Wed, Mar 17, 2010 at 06:12:14PM +0800, Steven Liu wrote:
> fix a code style in fs/ext4/move_extent.c
> 
> Signed-off-by: LiuQi <lingjiujianke@gmail.com>

I've added this to the ext4 patch queue with the following changelog
description:

ext4: Fix coding style in fs/ext4/move_extent.c

From: Steven Liu <lingjiujianke@gmail.com>

Making sure ee_block is initialized to zero to prevent gcc from
kvetching.  It's harmless (although it's not obvious that it's
harmless) from code inspection:

fs/ext4/move_extent.c:478: warning: 'start_ext.ee_block' may be used
uninitialized in this function

Thanks to Stefan Richter for first bringing this to the attention of
linux-ext4@vger.kernel.org.

Signed-off-by: LiuQi <lingjiujianke@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>

						- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-22  0:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-17 10:12 [PATCH] ext4: Fix coding style in fs/ext4/move_extent.c Steven Liu
2010-03-22  0:20 ` tytso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).