From: tytso@mit.edu
To: jing zhang <zj.barak@gmail.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator()
Date: Mon, 22 Mar 2010 14:26:45 -0400 [thread overview]
Message-ID: <20100322182645.GI11560@thunk.org> (raw)
In-Reply-To: <ac8f92701003220735h76b4a51dib1a9b311f9cf6d99@mail.gmail.com>
On Mon, Mar 22, 2010 at 10:35:54PM +0800, jing zhang wrote:
> From: Jing Zhang <zj.barak@gmail.com>
>
> Date: Mon Mar 22 22:20:38 2010
>
> 1, In one of the hot functions in mballoc.c, unnecessary operation on
> struct ext4_group_desc *desc;
> is removed.
>
> 2, Unlike spin_lock() and spin_unlock(), ext4_mb_load_buddy() is
> companied by ext4_mb_release_desc. And it is hard, at least for me, to
> get sure that ext4_mb_release_desc has little to do with struct
> ext4_group_desc, and for those readers as well, whose native language
> is not English. It seems the choice includes
> ext4_mb_release_buddy
> ext4_mb_put_buddy
> ext4_mb_unload_buddy
> and I like the last one.
Please separate things like this into two separate patches; it makes
them much easier to review.
Thanks,
- Ted
next prev parent reply other threads:[~2010-03-22 18:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 14:35 [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() jing zhang
2010-03-22 18:26 ` tytso [this message]
2010-03-23 12:40 ` jing zhang
2010-03-23 16:56 ` tytso
2010-03-24 12:14 ` jing zhang
2010-04-02 1:48 ` [PATCH 1/2] ext4: Remove unnecessary call to ext4_get_group_desc() in mballoc Theodore Ts'o
2010-04-02 1:48 ` [PATCH 2/2] ext4: rename ext4_mb_release_desc() to ext4_mb_unload_buddy() Theodore Ts'o
2010-03-24 17:23 ` [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() Aneesh Kumar K. V
2010-03-23 3:42 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322182645.GI11560@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=zj.barak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).