linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tytso@mit.edu
To: jing zhang <zj.barak@gmail.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
	Andreas Dilger <adilger@sun.com>,
	Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator()
Date: Tue, 23 Mar 2010 12:56:21 -0400	[thread overview]
Message-ID: <20100323165621.GO11560@thunk.org> (raw)
In-Reply-To: <ac8f92701003230540w5a788ec1s54737e2e38c90e11@mail.gmail.com>

Thanks for separating the patches!

Since you included a Signed-off-by in the earlier version of the
patches, I'll assume it applies two these two patches.  For future
reference, though, it saves me time and effort if you follow the
guidelines specified in Documentation/SubmittingPatches, especially
the section 15, ("The canonical patch format") which talks about using
a separate e-mail for each patch (chained together using the
In-reply-to: mail header fields).

Among other reasons, it allows me to keep track of patches using the
patchwork tool (see: http://patchwork.ozlabs.org/project/linux-ext4)
so I don't forget about patches which are sent to me.  It also allows
me to use tools such as "git am" to automatically apply patches.

Note that there are tools like "git format-patches" and "git
send-email" which make it very easy to send out patches which are
compliant to the these recomendations.  They are not required, but
they do make your job easier.

I'll fix up these patches by hand, so it's no big deal, but in the
future, it streamlines things if you follow the SubmittingPatches
guidelines.  (See also the SubmitChecklist in the Documentation
directory of the Linux sources).

Many thanks,

						- Ted

  reply	other threads:[~2010-03-23 16:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-22 14:35 [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() jing zhang
2010-03-22 18:26 ` tytso
2010-03-23 12:40   ` jing zhang
2010-03-23 16:56     ` tytso [this message]
2010-03-24 12:14       ` jing zhang
2010-04-02  1:48         ` [PATCH 1/2] ext4: Remove unnecessary call to ext4_get_group_desc() in mballoc Theodore Ts'o
2010-04-02  1:48         ` [PATCH 2/2] ext4: rename ext4_mb_release_desc() to ext4_mb_unload_buddy() Theodore Ts'o
2010-03-24 17:23     ` [PATCH] ext4: remove unnecessary operation in ext4_mb_regular_allocator() Aneesh Kumar K. V
2010-03-23  3:42 ` Andreas Dilger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100323165621.GO11560@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=shaggy@linux.vnet.ibm.com \
    --cc=zj.barak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).