linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH,RFC] Adding quotacheck functionality to e2fsck
Date: Fri, 26 Mar 2010 01:47:38 +0100	[thread overview]
Message-ID: <20100326004738.GJ3145@quack.suse.cz> (raw)
In-Reply-To: <E1NuxHe-0005cj-JN@closure.thunk.org>

  Hi Ted,

On Thu 25-03-10 20:20:18, Theodore Ts'o wrote:
> This is something I whipped up last night to speed up quotacheck by
> doing the data collection in e2fsck.  If e2fsck runs and does a full
> check, it's likely that quotacheck needs to be run as well --- and it's
> faster if e2fsck does the dirty work of fetching the information since
> (1) it needs to paw through all of the inodes anyway, and (2) quotacheck
> has to go through the file system and iterate over the files in an
> non-optimal order.
> 
> What do folks think?  Obviously changes in quotacheck would be required
> before it could take advantage of these output files, but hopefully that
> shouldn't be hard...
> 
> To use, either use:
> 
>    e2fsck -E usrquota_check=/tmp/quota.user,grpquota_check=/tmp/quota.group
> 
> or you can edit /etc/e2fsck.conf and add:
> 
> [quota]
> 	directory = /var/e2fsck/quota
> 
> I still need to write documentation, update the man pages, and do some
> polishing, so this is still in a pretty rough state, but I'd appreciate
> comments.
  This is definitely a move in the right direction. I'd be even happier
if e2fsck would write quota file directly - then we could just make
quota files hidden inodes, start doing quota accounting immediately
on mount and always do quota journaling. That would save us quite some
trouble in kernel. The only problem with this is that we'd need to pull
knowledge about quota formats in e2fsck...

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  reply	other threads:[~2010-03-26  0:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26  0:20 [PATCH,RFC] Adding quotacheck functionality to e2fsck Theodore Ts'o
2010-03-26  0:47 ` Jan Kara [this message]
2010-03-26  3:38   ` tytso
2010-03-26  7:01     ` Andreas Dilger
2010-03-26  8:18       ` Dmitry Monakhov
2010-03-26 10:57         ` Jan Kara
2010-03-26 11:15           ` Dmitry Monakhov
2010-03-26 16:27             ` Dmitry Monakhov
2010-03-29  7:35               ` Jan Kara
2010-03-29  7:50                 ` dmonakhov
2010-03-26 10:54       ` Jan Kara
2010-03-26 13:51         ` tytso
2010-03-30  0:43           ` Jan Kara
2010-03-26 10:42     ` Jan Kara
2010-03-26 13:38       ` tytso
2010-03-30  0:55         ` Jan Kara
2010-03-30  5:26           ` Dmitry Monakhov
2010-03-30 12:42             ` Jan Kara
2010-03-26  8:09   ` Dmitry Monakhov
2010-03-26 11:00     ` Jan Kara
2010-03-26 13:55     ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100326004738.GJ3145@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).