linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, jack@suse.cz
Subject: Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation
Date: Mon, 29 Mar 2010 16:21:35 +0200	[thread overview]
Message-ID: <20100329142135.GB5835@quack.suse.cz> (raw)
In-Reply-To: <1269620996-11400-1-git-send-email-dmonakhov@openvz.org>

On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
> generic setattr implementation is no longer responsible for
> quota transfer so synlinks must be handled via ext2_setattr.
  Ah, good catch. I'll merge ext2 and ext3 patch.

							Honza
> ---
>  fs/ext2/symlink.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
> index 4e2426e..565cf81 100644
> --- a/fs/ext2/symlink.c
> +++ b/fs/ext2/symlink.c
> @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>  	.readlink	= generic_readlink,
>  	.follow_link	= page_follow_link_light,
>  	.put_link	= page_put_link,
> +	.setattr	= ext2_setattr,
>  #ifdef CONFIG_EXT2_FS_XATTR
>  	.setxattr	= generic_setxattr,
>  	.getxattr	= generic_getxattr,
> @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>  const struct inode_operations ext2_fast_symlink_inode_operations = {
>  	.readlink	= generic_readlink,
>  	.follow_link	= ext2_follow_link,
> +	.setattr	= ext2_setattr,
>  #ifdef CONFIG_EXT2_FS_XATTR
>  	.setxattr	= generic_setxattr,
>  	.getxattr	= generic_getxattr,
> -- 
> 1.6.6.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  parent reply	other threads:[~2010-03-29 15:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 16:29 [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation Dmitry Monakhov
2010-03-26 16:29 ` [PATCH 2/3] ext3: " Dmitry Monakhov
2010-03-26 16:29   ` [PATCH 3/3] ext4: " Dmitry Monakhov
2010-04-04 20:05     ` tytso
2010-04-05  3:06       ` dmonakhov
2010-03-29 14:21 ` Jan Kara [this message]
2010-03-29 14:26   ` [PATCH 1/3] ext2: " Jan Kara
2010-03-29 15:28     ` dmonakhov
2010-03-29 15:24   ` dmonakhov
2010-03-29 15:58     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100329142135.GB5835@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=dmonakhov@openvz.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).