From: tytso@mit.edu
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: Re: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode
Date: Fri, 2 Apr 2010 17:48:31 -0400 [thread overview]
Message-ID: <20100402214831.GN8298@thunk.org> (raw)
In-Reply-To: <201003072132.10579.borntraeger@de.ibm.com>
On Sun, Mar 07, 2010 at 09:32:10PM +0100, Christian Borntraeger wrote:
> I have an x86_64 kernel with i386 userspace. e4defrag fails on the
> EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat
> case. It seems that struct move_extent is compat save, only types
> with fixed widths are used:
> {
> __u32 reserved; /* should be zero */
> __u32 donor_fd; /* donor file descriptor */
> __u64 orig_start; /* logical start offset in block for orig */
> __u64 donor_start; /* logical start offset in block for donor */
> __u64 len; /* block length to be moved */
> __u64 moved_len; /* moved block length */
> };
>
> Lets just wire up EXT4_IOC_MOVE_EXT for the compat case.
Thanks, added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2010-04-02 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 20:32 [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode Christian Borntraeger
2010-03-07 23:27 ` defrag deployment status (was Re: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode) Jeff Garzik
2010-03-08 5:43 ` Eric Sandeen
2010-03-08 7:53 ` Christian Borntraeger
2010-03-08 15:33 ` David Newall
2010-03-08 16:00 ` Christian Borntraeger
2010-03-08 16:22 ` jim owens
2010-03-08 16:31 ` Greg Freemyer
2010-03-08 17:11 ` jim owens
2010-03-09 13:23 ` jim owens
2010-03-08 19:38 ` Valdis.Kletnieks
2010-03-08 20:48 ` jim owens
2010-03-09 16:19 ` David Newall
2010-03-08 5:47 ` [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode Eric Sandeen
2010-03-08 8:42 ` Akira Fujita
2010-03-12 7:01 ` [PATCH resend] " Christian Borntraeger
2010-04-02 21:48 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100402214831.GN8298@thunk.org \
--to=tytso@mit.edu \
--cc=a-fujita@rs.jp.nec.com \
--cc=borntraeger@de.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).