[PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[Dmitry Monakhov]

generic setattr implementation is no longer responsible for
quota transfer so synlinks must be handled via ext2_setattr.
---
 fs/ext2/symlink.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
index 4e2426e..565cf81 100644
--- a/fs/ext2/symlink.c
+++ b/fs/ext2/symlink.c
@@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= page_follow_link_light,
 	.put_link	= page_put_link,
+	.setattr	= ext2_setattr,
 #ifdef CONFIG_EXT2_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
@@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
 const struct inode_operations ext2_fast_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= ext2_follow_link,
+	.setattr	= ext2_setattr,
 #ifdef CONFIG_EXT2_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
-- 
1.6.6.1

[PATCH 2/3] ext3: symlink must be handled via filesystem specific operation

[Dmitry Monakhov]

generic setattr implementation is no longer responsible for
quota transfer so synlinks must be handled via ext3_setattr.
---
 fs/ext3/symlink.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext3/symlink.c b/fs/ext3/symlink.c
index ff7b4cc..7c48982 100644
--- a/fs/ext3/symlink.c
+++ b/fs/ext3/symlink.c
@@ -34,6 +34,7 @@ const struct inode_operations ext3_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= page_follow_link_light,
 	.put_link	= page_put_link,
+	.setattr	= ext3_setattr,
 #ifdef CONFIG_EXT3_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
@@ -45,6 +46,7 @@ const struct inode_operations ext3_symlink_inode_operations = {
 const struct inode_operations ext3_fast_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= ext3_follow_link,
+	.setattr	= ext3_setattr,
 #ifdef CONFIG_EXT3_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
-- 
1.6.6.1

[PATCH 3/3] ext4: symlink must be handled via filesystem specific operation

[Dmitry Monakhov]

generic setattr implementation is no longer responsible for
quota transfer so synlinks must be handled via ext4_setattr.
---
 fs/ext4/symlink.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/symlink.c b/fs/ext4/symlink.c
index 00740cb..ed9354a 100644
--- a/fs/ext4/symlink.c
+++ b/fs/ext4/symlink.c
@@ -34,6 +34,7 @@ const struct inode_operations ext4_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= page_follow_link_light,
 	.put_link	= page_put_link,
+	.setattr	= ext4_setattr,
 #ifdef CONFIG_EXT4_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
@@ -45,6 +46,7 @@ const struct inode_operations ext4_symlink_inode_operations = {
 const struct inode_operations ext4_fast_symlink_inode_operations = {
 	.readlink	= generic_readlink,
 	.follow_link	= ext4_follow_link,
+	.setattr	= ext4_setattr,
 #ifdef CONFIG_EXT4_FS_XATTR
 	.setxattr	= generic_setxattr,
 	.getxattr	= generic_getxattr,
-- 
1.6.6.1

Re: [PATCH 3/3] ext4: symlink must be handled via filesystem specific operation

[tytso]

On Fri, Mar 26, 2010 at 07:29:56PM +0300, Dmitry Monakhov wrote:
> generic setattr implementation is no longer responsible for
> quota transfer so synlinks must be handled via ext4_setattr.

Added to the ext4 patch queue; I've added a Signed-off-by: for you
Dmitry, per your e-mail to Jan Kara.

(There seems to be some random confused people who think the
Signed-off-by has no legal significance, which is absolutely not true.)

	      	     	   		       - Ted

Re: [PATCH 3/3] ext4: symlink must be handled via filesystem specific operation

[dmonakhov]

tytso@mit.edu writes:

> On Fri, Mar 26, 2010 at 07:29:56PM +0300, Dmitry Monakhov wrote:
>> generic setattr implementation is no longer responsible for
>> quota transfer so synlinks must be handled via ext4_setattr.
>
> Added to the ext4 patch queue; I've added a Signed-off-by: for you
> Dmitry, per your e-mail to Jan Kara.
>
> (There seems to be some random confused people who think the
> Signed-off-by has no legal significance, which is absolutely not true.)
yep. Changed my gitconfig to prevent this type of things in future.
BTW: IMHO This patch is also valid for all stable releases.
Because currently chown is not journalled for symlinks.
So journalled quota may becomes inconsistent after power-failure.

Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[Jan Kara]

On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
> generic setattr implementation is no longer responsible for
> quota transfer so synlinks must be handled via ext2_setattr.
  Ah, good catch. I'll merge ext2 and ext3 patch.

							Honza
> ---
>  fs/ext2/symlink.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
> index 4e2426e..565cf81 100644
> --- a/fs/ext2/symlink.c
> +++ b/fs/ext2/symlink.c
> @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>  	.readlink	= generic_readlink,
>  	.follow_link	= page_follow_link_light,
>  	.put_link	= page_put_link,
> +	.setattr	= ext2_setattr,
>  #ifdef CONFIG_EXT2_FS_XATTR
>  	.setxattr	= generic_setxattr,
>  	.getxattr	= generic_getxattr,
> @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>  const struct inode_operations ext2_fast_symlink_inode_operations = {
>  	.readlink	= generic_readlink,
>  	.follow_link	= ext2_follow_link,
> +	.setattr	= ext2_setattr,
>  #ifdef CONFIG_EXT2_FS_XATTR
>  	.setxattr	= generic_setxattr,
>  	.getxattr	= generic_getxattr,
> -- 
> 1.6.6.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[Jan Kara]

On Mon 29-03-10 16:21:35, Jan Kara wrote:
> On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
> > generic setattr implementation is no longer responsible for
> > quota transfer so synlinks must be handled via ext2_setattr.
>   Ah, good catch. I'll merge ext2 and ext3 patch.
  BTW, you forgot to add your signed-off-by. I'll take the liberty
of adding it but please confirm so that we don't set a bad precedens
(this legal stuff is sensitive...).

 							Honza
> > ---
> >  fs/ext2/symlink.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
> > index 4e2426e..565cf81 100644
> > --- a/fs/ext2/symlink.c
> > +++ b/fs/ext2/symlink.c
> > @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
> >  	.readlink	= generic_readlink,
> >  	.follow_link	= page_follow_link_light,
> >  	.put_link	= page_put_link,
> > +	.setattr	= ext2_setattr,
> >  #ifdef CONFIG_EXT2_FS_XATTR
> >  	.setxattr	= generic_setxattr,
> >  	.getxattr	= generic_getxattr,
> > @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
> >  const struct inode_operations ext2_fast_symlink_inode_operations = {
> >  	.readlink	= generic_readlink,
> >  	.follow_link	= ext2_follow_link,
> > +	.setattr	= ext2_setattr,
> >  #ifdef CONFIG_EXT2_FS_XATTR
> >  	.setxattr	= generic_setxattr,
> >  	.getxattr	= generic_getxattr,
> > -- 
> > 1.6.6.1
> > 
> -- 
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[dmonakhov]

Jan Kara <jack@suse.cz> writes:

> On Mon 29-03-10 16:21:35, Jan Kara wrote:
>> On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
>> > generic setattr implementation is no longer responsible for
>> > quota transfer so synlinks must be handled via ext2_setattr.
>>   Ah, good catch. I'll merge ext2 and ext3 patch.
>   BTW, you forgot to add your signed-off-by. I'll take the liberty
> of adding it but please confirm so that we don't set a bad precedens
> (this legal stuff is sensitive...).
yes. It was me (Dmitry Monakhov). 
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>
>  							Honza
>> > ---
>> >  fs/ext2/symlink.c |    2 ++
>> >  1 files changed, 2 insertions(+), 0 deletions(-)
>> > 
>> > diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
>> > index 4e2426e..565cf81 100644
>> > --- a/fs/ext2/symlink.c
>> > +++ b/fs/ext2/symlink.c
>> > @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>> >  	.readlink	= generic_readlink,
>> >  	.follow_link	= page_follow_link_light,
>> >  	.put_link	= page_put_link,
>> > +	.setattr	= ext2_setattr,
>> >  #ifdef CONFIG_EXT2_FS_XATTR
>> >  	.setxattr	= generic_setxattr,
>> >  	.getxattr	= generic_getxattr,
>> > @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>> >  const struct inode_operations ext2_fast_symlink_inode_operations = {
>> >  	.readlink	= generic_readlink,
>> >  	.follow_link	= ext2_follow_link,
>> > +	.setattr	= ext2_setattr,
>> >  #ifdef CONFIG_EXT2_FS_XATTR
>> >  	.setxattr	= generic_setxattr,
>> >  	.getxattr	= generic_getxattr,
>> > -- 
>> > 1.6.6.1
>> > 
>> -- 
>> Jan Kara <jack@suse.cz>
>> SUSE Labs, CR

Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[dmonakhov]

Jan Kara <jack@suse.cz> writes:

> On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
>> generic setattr implementation is no longer responsible for
>> quota transfer so synlinks must be handled via ext2_setattr.
>   Ah, good catch. I'll merge ext2 and ext3 patch.
Same issue for ufs/udf/jfs
Should i send as combined patch or as a separate fixes?
>
> 							Honza
>> ---
>>  fs/ext2/symlink.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>> 
>> diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
>> index 4e2426e..565cf81 100644
>> --- a/fs/ext2/symlink.c
>> +++ b/fs/ext2/symlink.c
>> @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>>  	.readlink	= generic_readlink,
>>  	.follow_link	= page_follow_link_light,
>>  	.put_link	= page_put_link,
>> +	.setattr	= ext2_setattr,
>>  #ifdef CONFIG_EXT2_FS_XATTR
>>  	.setxattr	= generic_setxattr,
>>  	.getxattr	= generic_getxattr,
>> @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
>>  const struct inode_operations ext2_fast_symlink_inode_operations = {
>>  	.readlink	= generic_readlink,
>>  	.follow_link	= ext2_follow_link,
>> +	.setattr	= ext2_setattr,
>>  #ifdef CONFIG_EXT2_FS_XATTR
>>  	.setxattr	= generic_setxattr,
>>  	.getxattr	= generic_getxattr,
>> -- 
>> 1.6.6.1
>> 

Re: [PATCH 1/3] ext2: symlink must be handled via filesystem specific operation

[Jan Kara]

> Jan Kara <jack@suse.cz> writes:
> 
> > On Fri 26-03-10 19:29:54, Dmitry Monakhov wrote:
> >> generic setattr implementation is no longer responsible for
> >> quota transfer so synlinks must be handled via ext2_setattr.
> >   Ah, good catch. I'll merge ext2 and ext3 patch.
> Same issue for ufs/udf/jfs
> Should i send as combined patch or as a separate fixes?
  I think separate patches are fine.

							Honza

> >> ---
> >>  fs/ext2/symlink.c |    2 ++
> >>  1 files changed, 2 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c
> >> index 4e2426e..565cf81 100644
> >> --- a/fs/ext2/symlink.c
> >> +++ b/fs/ext2/symlink.c
> >> @@ -32,6 +32,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
> >>  	.readlink	= generic_readlink,
> >>  	.follow_link	= page_follow_link_light,
> >>  	.put_link	= page_put_link,
> >> +	.setattr	= ext2_setattr,
> >>  #ifdef CONFIG_EXT2_FS_XATTR
> >>  	.setxattr	= generic_setxattr,
> >>  	.getxattr	= generic_getxattr,
> >> @@ -43,6 +44,7 @@ const struct inode_operations ext2_symlink_inode_operations = {
> >>  const struct inode_operations ext2_fast_symlink_inode_operations = {
> >>  	.readlink	= generic_readlink,
> >>  	.follow_link	= ext2_follow_link,
> >> +	.setattr	= ext2_setattr,
> >>  #ifdef CONFIG_EXT2_FS_XATTR
> >>  	.setxattr	= generic_setxattr,
> >>  	.getxattr	= generic_getxattr,
> >> -- 
> >> 1.6.6.1
> >> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs