From: tytso@mit.edu
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4_freeze: don't return to userspace with a mutex held
Date: Sun, 4 Apr 2010 16:52:37 -0400 [thread overview]
Message-ID: <20100404205237.GK18524@thunk.org> (raw)
In-Reply-To: <4BB12B03.9070906@redhat.com>
On Mon, Mar 29, 2010 at 05:34:43PM -0500, Eric Sandeen wrote:
>
> I don't -think- we need to do this; by now we should have s_frozen
> set, and nobody else should be coming down the pipe to get to
> the journal. However, just to be on the safe side, I added
> a couple of vfs_check_frozen() calls in ext4 functions which will
> arrive at start_this_handle(), which should ensure that we never
> get any journal traffic generated while frozen.
Um, I think the addition of vfs_check_frozen(), esp. to
ext4_journal_start_sb() is absolutely necessary. What else do we have
to prevent filesystem modifications from going to the file systme
layer? I didn't see anything in the VFS layer that checks s_frozen;
am I missing something?
- Ted
next prev parent reply other threads:[~2010-04-04 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 22:34 [PATCH] ext4_freeze: don't return to userspace with a mutex held Eric Sandeen
2010-04-04 20:52 ` tytso [this message]
2010-04-04 21:03 ` tytso
2010-04-04 21:23 ` Eric Sandeen
2010-04-04 21:56 ` Theodore Tso
2010-04-05 0:43 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100404205237.GK18524@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).