linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tytso@mit.edu
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Jeff Moyer <jmoyer@redhat.com>, Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	jens.axboe@oracle.com, esandeen@redhat.com
Subject: Re: [patch/rft] jbd2: tag journal writes as metadata I/O
Date: Tue, 6 Apr 2010 14:45:05 -0400	[thread overview]
Message-ID: <20100406184505.GL23670@thunk.org> (raw)
In-Reply-To: <20100406182527.GF3029@redhat.com>

> CFQ currently seems to be preempting any thread doing IO if a request has
> been marked as metadata. I think this is going to be bad for any other IO
> going on.
> 
> I wrote a small fio script which is doing buffered writes with bs=32K and I
> am doing fsync on file after every 20 IOs (fsync=20). I am assuming that this
> something close to writting a small file and then doing fsync on that. 
> 
> With that fio script running I launched firefox and measured the
> time it takes.....  it looks like that firefox launching times have
> seems to just almost doubled.

Vivek, thanks for pointing this out.  Sounds like we need to think
carefully about whether the potential unfairness that this patch might
impose on other workloads sharing the file system dominates the
improvements that Jeff found when there's only a single workload
running on the file system.

I'm tentatively leaning towards pulling this patch so we can do more
testing / benchmarking.   Jeff, any thoughts or comments?

						- Ted

  reply	other threads:[~2010-04-06 18:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 19:04 [patch/rft] jbd2: tag journal writes as metadata I/O Jeff Moyer
2010-04-01 19:48 ` Jan Kara
2010-04-05 15:24   ` Jeff Moyer
2010-04-05 17:46     ` tytso
2010-04-06 15:20       ` Jan Kara
2010-04-06 18:25       ` Vivek Goyal
2010-04-06 18:45         ` tytso [this message]
2010-04-06 19:04           ` Jeff Moyer
2010-04-02  7:00 ` Jens Axboe
2010-04-05 17:52 ` tytso
2010-04-05 18:36   ` Jeff Moyer
2010-04-05 19:48     ` tytso
2010-04-05 20:34       ` Jeff Moyer
2010-04-05 20:41         ` Jeff Moyer
2010-04-05 21:01           ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100406184505.GL23670@thunk.org \
    --to=tytso@mit.edu \
    --cc=esandeen@redhat.com \
    --cc=jack@suse.cz \
    --cc=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).