From: tytso@mit.edu
To: jing zhang <zj.barak@gmail.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
linux-ext4 <linux-ext4@vger.kernel.org>,
"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>,
Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: BUG_ON triggered in ext4_mb_complex_scan_group()
Date: Wed, 7 Apr 2010 11:31:05 -0400 [thread overview]
Message-ID: <20100407153105.GR23670@thunk.org> (raw)
In-Reply-To: <i2gac8f92701004042201gbe239f33la21b31828752fd3c@mail.gmail.com>
On Mon, Apr 05, 2010 at 01:01:31PM +0800, jing zhang wrote:
> 2010/4/5, Eric Sandeen <sandeen@redhat.com>:
> > jing zhang wrote:
> >> From: Jing Zhang <zj.barak@gmail.com>
> >>
> >> Date: Mon Apr 5 12:10:50 2010
> >>
> >> BUG_ON is triggered at [line:1762] in ext4_mb_complex_scan_group(),
> >
> > Do you have a test case which can trigger this BUG_ON?
> >
> > -Eric
>
> No I do not have.
>
> But you can check [line: 1762] and [line: 1321].
>
> And please info me the result, if you like, after check.
Again, line numbers make it hard to determine what you're talking
about. And we need a scenario description that might trigger this.
If you can't give it, then my fear is that you don't understand how
the code is used, in which case the risk is extremely high that that
your patch will not be correct, and may in fact may make things worse.
I could spend time trying to reverse engineer the scenario where this
might happen, but the fact of the matter is, no one has reported these
BUG_ON's ever triggering as far as I know. So when I have free time,
I might get back to looking for them. Otherwise, I have higher
priority things to work on, and it's going to be up to you to pursuade
me that this could actually happen in real life, and how.
Best regards,
- Ted
prev parent reply other threads:[~2010-04-07 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 4:30 [PATCH] ext4: BUG_ON triggered in ext4_mb_complex_scan_group() jing zhang
2010-04-05 4:36 ` Eric Sandeen
2010-04-05 5:01 ` jing zhang
2010-04-07 15:31 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407153105.GR23670@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=shaggy@linux.vnet.ibm.com \
--cc=zj.barak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).