From: bugzilla-daemon@bugzilla.kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 15792] ext4_inode_inode->i_flags modification is racy
Date: Thu, 15 Apr 2010 22:52:29 GMT [thread overview]
Message-ID: <201004152252.o3FMqTdl006732@demeter.kernel.org> (raw)
In-Reply-To: <bug-15792-13602@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=15792
--- Comment #4 from Dmitry Monakhov <dmonakhov@openvz.org> 2010-04-15 22:52:22 ---
Most interesting part is last lines
[61] [2] truncate clr s:737987 d:737987 b:104 fl:80000
[62] [0] clr ext4_inode_blocks_set b:104 fl:480000 bit:40000
[63] [2] trunc_ext begin s:737987 d:737987 b:104 fl:480000 ml:1
I.E.
CPU2: is doing EXT4_I(inode)->i_flags &= ~EXT4_EOFBLOCKS_FL
CPU0: is doung ei->i_flags &= ~EXT4_HUGE_FILE_FL
CPU2: Wow EXT4_EOFBLOCKS_FL appear again due to race with cpu0.
So even if truncate holds i_mutex it is possible to modify i_flags.
Seems that we have to modify i_flags via anomic bits operations.
A fix is almost ready. Currently i'm testing it.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
next prev parent reply other threads:[~2010-04-15 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 22:13 [Bug 15792] New: ext4_inode_inode->i_flags modification is racy bugzilla-daemon
2010-04-15 22:17 ` [Bug 15792] " bugzilla-daemon
2010-04-15 22:31 ` bugzilla-daemon
2010-04-15 22:39 ` bugzilla-daemon
2010-04-15 22:40 ` bugzilla-daemon
2010-04-15 22:52 ` bugzilla-daemon [this message]
2010-04-15 22:54 ` [Bug 15792] ext4_inode_info->i_flags " bugzilla-daemon
2010-04-19 3:43 ` bugzilla-daemon
2010-04-19 14:38 ` bugzilla-daemon
2010-07-06 7:15 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004152252.o3FMqTdl006732@demeter.kernel.org \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).