From: Jamie Lokier <jamie@shareable.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Valerie Aurora <vaurora@redhat.com>,
jblunck@suse.de, dwmw2@infradead.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 13/35] fallthru: ext2 fallthru support
Date: Tue, 20 Apr 2010 22:34:50 +0100 [thread overview]
Message-ID: <20100420213450.GM11723@shareable.org> (raw)
In-Reply-To: <E1O3sLi-0008EA-QW@pomaz-ex.szeredi.hu>
Miklos Szeredi wrote:
> On Mon, 19 Apr 2010, Valerie Aurora wrote:
> > I don't recall there being any technical reason not to look up the
> > real inode number. I just wrote it that we because I was lazy. So I
> > like returning the directory's d_ino better than a single magic
> > number, but I'd at least like to try returning the real inode number
> > too.
>
> Note, "struct dirent" doesn't have d_dev, so you really can't return
> the "real" inode number, that's on a different filesystem and just a
> random number in the context of the the readdir in question.
Agree. Does this inappropriate inode number for the union mount's
st_dev happen with stat() on the actual files too? That could be bad.
-- Jamie
next prev parent reply other threads:[~2010-04-20 21:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1271372682-21225-1-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-2-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-3-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-4-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-5-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-6-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-7-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-8-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-9-git-send-email-vaurora@redhat.com>
2010-04-15 23:04 ` [PATCH 09/35] whiteout: Split of ext2_append_link() from ext2_add_link() Valerie Aurora
2010-04-15 23:04 ` [PATCH 10/35] whiteout: ext2 whiteout support Valerie Aurora
[not found] ` <1271372682-21225-12-git-send-email-vaurora@redhat.com>
[not found] ` <1271372682-21225-13-git-send-email-vaurora@redhat.com>
2010-04-15 23:04 ` [PATCH 13/35] fallthru: ext2 fallthru support Valerie Aurora
2010-04-19 12:40 ` Jan Blunck
2010-04-19 13:02 ` David Woodhouse
2010-04-19 13:23 ` Jan Blunck
2010-04-19 13:30 ` Jamie Lokier
2010-04-19 14:12 ` Jan Blunck
2010-04-19 14:23 ` Valerie Aurora
2010-04-19 14:53 ` Miklos Szeredi
2010-04-20 21:34 ` Jamie Lokier [this message]
2010-04-21 8:42 ` Jan Blunck
2010-04-21 9:22 ` Jamie Lokier
2010-04-21 9:34 ` Miklos Szeredi
2010-04-21 9:52 ` Jamie Lokier
2010-04-21 10:17 ` Miklos Szeredi
2010-04-21 17:36 ` Jamie Lokier
2010-04-21 21:34 ` Valerie Aurora
2010-04-21 21:38 ` Valerie Aurora
2010-04-21 22:10 ` Jamie Lokier
2010-04-22 10:30 ` J. R. Okajima
2010-04-20 21:40 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420213450.GM11723@shareable.org \
--to=jamie@shareable.org \
--cc=dwmw2@infradead.org \
--cc=jblunck@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).