From: Nikanth Karthikesan <knikanth@suse.de>
To: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
linux-ext4@vger.kernel.org
Cc: "Amit K. Arora" <aarora@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
coly.li@suse.de, Nick Piggin <npiggin@suse.de>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Eelis <opensuse.org@contacts.eelis.net>,
Amit Arora <aarora@in.ibm.com>,
Christoph Hellwig <hch@infradead.org>
Subject: [PATCH] ext4: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
Date: Tue, 4 May 2010 11:15:04 +0530 [thread overview]
Message-ID: <201005041115.04400.knikanth@suse.de> (raw)
In-Reply-To: <20100503065945.GA13756@amitarora.in.ibm.com>
I assumed that Amit would send a patch with s-o-b, if not, please take
this patch.
Thanks
Nikanth
Prevent creation of files larger than RLIMIT_FSIZE using fallocate.
Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a file larger than the limit. Add a check for that.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 236b834..39b8123 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3672,6 +3672,11 @@ long ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t len)
*/
credits = ext4_chunk_trans_blocks(inode, max_blocks);
mutex_lock(&inode->i_mutex);
+ ret = inode_newsize_ok(inode, (len + offset));
+ if (ret) {
+ mutex_unlock(&inode->i_mutex);
+ return ret;
+ }
retry:
while (ret >= 0 && ret < max_blocks) {
block = block + ret;
next prev parent reply other threads:[~2010-05-04 5:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 13:24 [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan
2010-04-28 16:15 ` Coly Li
[not found] ` <201004291014.07194.knikanth@suse.de>
[not found] ` <4BD9239D.6060907@suse.de>
2010-04-29 9:23 ` Andreas Dilger
2010-04-30 21:33 ` Andrew Morton
2010-04-30 21:40 ` Andreas Dilger
2010-05-01 7:04 ` Amit K. Arora
2010-05-01 10:18 ` Christoph Hellwig
2010-05-03 7:01 ` Amit K. Arora
2010-05-03 8:31 ` [PATCH] New testcase to check if fallocate respects RLIMIT_FSIZE or not Amit K. Arora
2010-05-04 20:44 ` Eric Sandeen
2010-05-05 7:55 ` [PATCH v2] " Amit K. Arora
2010-05-05 15:50 ` Eric Sandeen
2010-05-03 4:23 ` [PATCH] Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan
2010-05-03 6:59 ` Amit K. Arora
2010-05-03 7:49 ` Nikanth Karthikesan
2010-05-04 5:44 ` [PATCH] btrfs: " Nikanth Karthikesan
2010-05-04 5:45 ` Nikanth Karthikesan [this message]
2010-05-04 6:28 ` [PATCH] ext4: " Amit K. Arora
2010-05-21 1:11 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005041115.04400.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=aarora@in.ibm.com \
--cc=aarora@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=coly.li@suse.de \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=opensuse.org@contacts.eelis.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).