* [PATCH] mke2fs: be explicit if external journal device is not found
@ 2010-04-01 19:26 Eric Sandeen
2010-05-12 16:54 ` tytso
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2010-04-01 19:26 UTC (permalink / raw)
To: ext4 development; +Cc: Richard W.M. Jones
This for RH bug #572935 -
RFE: Misleading error message from mke2fs -J option
If the journal device UUID is typo'd or otherwise not found,
the error message looks like it's a usage() type of problem.
It'd be helpful to explicitly say that the device requested
could not be found.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/misc/util.c b/misc/util.c
index b8a3cac..51bdb60 100644
--- a/misc/util.c
+++ b/misc/util.c
@@ -207,6 +207,10 @@ void parse_journal_opts(const char *opts)
if (strcmp(token, "device") == 0) {
journal_device = blkid_get_devname(NULL, arg, NULL);
if (!journal_device) {
+ if (arg)
+ fprintf(stderr, _("\nCould not find "
+ "journal device matching %s\n"),
+ arg);
journal_usage++;
continue;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-12 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-01 19:26 [PATCH] mke2fs: be explicit if external journal device is not found Eric Sandeen
2010-05-12 16:54 ` tytso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).