From: tytso@mit.edu
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz,
aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [PATCH] ext4: restart ext4_ext_remove_space() after transaction restart V2
Date: Wed, 26 May 2010 09:23:52 -0400 [thread overview]
Message-ID: <20100526132352.GA29528@thunk.org> (raw)
In-Reply-To: <87pr0ilw3n.fsf_-_@openvz.org>
One more thing. Why do you need EXT4_STATE_EXT_TRUNC?
The only place which tests it in any kind of real way is
ext4_ext_truncate_extend_restart(), and it is only called by one
function, ext4_ext_rm_leaf(), and *it* is only called in one place,
inside ext4_ext_remove_space(), and *it* surronds the call with
ext4_set_inode_state(inode, EXT4_STATE_EXT_TRUNC) and
ext4_clear_inode_state(inode, EXT4_STATE_EXT_TRUNC).
And while a truncate is happening, no other block allocation can
happen, so the test in ext4_ext_map_blocks() doesn't seem to do much.
(It only clears STATE_EXT_TRUNC if it is set and if the flags
EXT4_GET_BLOCKS_CREATE is set. I'm not sure what the point of that
is, either.)
- Ted
next prev parent reply other threads:[~2010-05-26 13:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 4:31 [PATCH] ext4: restart ext4_ext_remove_space() after transaction restart Dmitry Monakhov
2010-04-22 7:33 ` Dmitry Monakhov
2010-04-26 16:09 ` Jan Kara
2010-05-25 13:32 ` tytso
2010-05-25 14:28 ` Dmitry Monakhov
2010-05-25 21:38 ` tytso
2010-05-26 8:53 ` Dmitry Monakhov
2010-05-25 21:44 ` tytso
2010-05-26 9:12 ` Dmitry Monakhov
2010-05-26 11:51 ` [PATCH] ext4: restart ext4_ext_remove_space() after transaction restart V2 Dmitry Monakhov
2010-05-26 13:23 ` tytso [this message]
2010-05-26 13:46 ` Jan Kara
2010-05-26 14:23 ` Dmitry Monakhov
2010-05-26 14:45 ` tytso
2010-05-26 14:47 ` tytso
2010-05-26 17:22 ` Dmitry Monakhov
2010-05-25 13:55 ` [PATCH] ext4: restart ext4_ext_remove_space() after transaction restart tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526132352.GA29528@thunk.org \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).