From: Jan Kara <jack@suse.cz>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Jan Kara <jack@suse.cz>, tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Always journal quota file modifications
Date: Thu, 3 Jun 2010 13:54:40 +0200 [thread overview]
Message-ID: <20100603115439.GA3814@quack.suse.cz> (raw)
In-Reply-To: <87eigo1o2q.fsf@openvz.org>
On Thu 03-06-10 13:07:41, Dmitry Monakhov wrote:
> Jan Kara <jack@suse.cz> writes:
>
> > When journaled quota options are not specified, we do writes
> > to quota files just in data=ordered mode. This actually causes
> > warnings from JBD2 about dirty journaled buffer because ext4_getblk
> > unconditionally treats a block allocated by it as metadata. Since
> > quota actually is filesystem metadata, the easiest way to get rid
> > of the warning is to always treat quota writes as metadata...
> Absolutely agree with the fix, but I have a theoretical question.
> Is is possible to solve the issue without handling quota's bh
> via ext4_handle_dirty_metadata()?
> As soon as i understand ext4_jbd2_file_inode() not works here
> because bh is belongs to blkdev page-cache. In other words is it
> possible provide ordering for blkdev's blocks in jbd2?
You are right. It's not possible to provide ordering for blkdev's blocks
in JBD2 (unlike JBD). So a different solution would be rather problematic.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-06-03 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 14:23 [PATCH] ext4: Always journal quota file modifications Jan Kara
2010-06-02 21:39 ` Eric Sandeen
2010-06-02 23:46 ` Jan Kara
2010-06-03 9:07 ` Dmitry Monakhov
2010-06-03 11:54 ` Jan Kara [this message]
2010-06-03 12:53 ` tytso
2010-06-03 14:13 ` Dmitry Monakhov
2010-06-03 14:19 ` Jan Kara
2010-06-03 17:10 ` tytso
2010-06-04 14:45 ` Jan Kara
2010-06-03 16:47 ` Bernd Schubert
2010-07-05 20:08 ` Eric Sandeen
2010-07-27 13:37 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603115439.GA3814@quack.suse.cz \
--to=jack@suse.cz \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).