From: 陳炫廷 <acht93@cs.ccu.edu.tw>
To: linux-ext4@vger.kernel.org
Subject: Re: E2fsprogs master branch now has all 64-bit patch applied
Date: Mon, 21 Jun 2010 21:59:50 +0800 [thread overview]
Message-ID: <20100621215950.96874n172zixms2s@mail.cs.ccu.edu.tw> (raw)
Hi Ted,
Resize seems not work when the size is bigger than 16TB (offline resize).
My test machine:
x64 platform 2.6.32 kernel + this newest patch
1. <16TB ext4 enlarge to >16TB (offline)
a. I use "8 x 2TB WD disks" and "mdadm" build linear raid
b. then use mkfs.ext4 to make ext4 file system
c. grow the linear raid to "10 X 2TB"
d. finally it grow to "2.X TB" smaller than before
2. >16TB offline resize, the steps is similiar as before.
a. I use "9 x 2TB WD disks" build linear raid
b. mkfs.ext4 and not mount
c. grow the linear raid to "10 X 2TB"
d. do resize
e. finally it grow to "2.X TB" smaller than before
*. Base on my trace, seems the "EXT4_FEATURE_INCOMPAT_64BIT"
not on when mkfs.ext4. So the new_size is wrong when do "resize",
*. When do resize, "EXT2_FLAG_64BITS" not add to fs->flags.
So when execute "ext2fs_allocate_block_bitmap" function in resize process,
it won't go to 64bit check path.
*. And in "adjust_fs_info" function, I think should modify the following code
- fs->desc_blocks = ext2fs_div_ceil(fs->group_desc_count,
+ fs->desc_blocks = ext2fs_div64_ceil(fs->group_desc_count,
EXT2_DESC_PER_BLOCK(fs->super));
I try to on "EXT4_FEATURE_INCOMPAT_64BIT" and "EXT2_FLAG_64BITS"
when mkfs and resize.
And modify ext2fs_div_ceil code to ext2fs_div64_ceil.
It seems work something, the fs size isn't grow but also not deduce,
remain the same.
If you have any new patch, I can help to test. Thanks.
-HsuanTing
Best Regards,
next reply other threads:[~2010-06-21 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 13:59 陳炫廷 [this message]
[not found] <AANLkTilD3D2QOXi1b7oXT2uFBx_vuO803HOX4JJXfWG0@mail.gmail.com>
2010-06-21 17:05 ` E2fsprogs master branch now has all 64-bit patch applied tytso
2010-06-22 9:15 ` Hsuan-Ting
2010-06-22 16:17 ` Andreas Dilger
2010-06-23 8:42 ` Hsuan-Ting
2010-06-23 11:00 ` Hsuan-Ting
2010-06-25 10:33 ` Hsuan-Ting
2010-06-25 18:23 ` Andreas Dilger
2010-06-29 13:41 ` Hsuan-Ting
-- strict thread matches above, loose matches on Subject: below --
2010-06-21 17:02 Andreas Dilger
2010-06-14 13:39 Theodore Ts'o
2010-06-14 14:41 ` Eric Sandeen
2010-06-14 14:46 ` Ric Wheeler
2010-06-14 20:15 ` Eric Sandeen
2010-06-14 20:26 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621215950.96874n172zixms2s@mail.cs.ccu.edu.tw \
--to=acht93@cs.ccu.edu.tw \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).