From: Christoph Hellwig <hch@infradead.org>
To: Jiaying Zhang <jiayingz@google.com>
Cc: hch@infradead.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, tytso@mit.edu, c@google.com
Subject: Re: [PATCH] EXT4: move aio completion after unwritten extent conversion
Date: Mon, 28 Jun 2010 10:49:56 -0400 [thread overview]
Message-ID: <20100628144956.GA21331@infradead.org> (raw)
In-Reply-To: <20100624221534.299B62008@ruihe.smo.corp.google.com>
> if (io_end->flag != EXT4_IO_UNWRITTEN){
> ext4_free_io_end(io_end);
> iocb->private = NULL;
> - goto out;
> +out:
> + if (is_async)
> + aio_complete(iocb, ret, 0);
> + return;
I'd suggest keeping the out label at the end of the function. Without
that the code gets unreadable very quickly.
> io_end->size = size;
> - io_end->flag = EXT4_IO_UNWRITTEN;
Why is this initialization removed?
next prev parent reply other threads:[~2010-06-28 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 22:15 [PATCH] EXT4: move aio completion after unwritten extent conversion Jiaying Zhang
2010-06-28 14:49 ` Christoph Hellwig [this message]
2010-06-28 18:41 ` Jiaying Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628144956.GA21331@infradead.org \
--to=hch@infradead.org \
--cc=c@google.com \
--cc=jiayingz@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).