From: tytso@mit.edu
To: Nebojsa Trpkovic <trx.lists@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: lifetime_write_kbytes isn't preserved during unclean shutdown
Date: Mon, 28 Jun 2010 15:57:39 -0400 [thread overview]
Message-ID: <20100628195739.GB6094@thunk.org> (raw)
In-Reply-To: <4C2782A7.7040301@gmail.com>
On Sun, Jun 27, 2010 at 06:56:07PM +0200, Nebojsa Trpkovic wrote:
> I've noticed that lifetime_write_kbytes isn't preserved during unclean
> shutdown.
Yes, right now we are only updating the superblock's lifetime write
kbytes at unmount time. It should be possible to do a better job; but
I don't want to increase writes to the disk just to keep the
s_lifetime value up-to-date. So what we should probably do is update
it when we are going to be updating the superblock anyway (i.e., when
we update the orphaned inode linked list) and maybe on some periodic
basis (say once an hour) otherwise.
Thanks for reporting this. I'll put it on my backlog queue, unless
someone beats me to submitting a patch....
- Ted
next prev parent reply other threads:[~2010-06-28 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-27 16:56 lifetime_write_kbytes isn't preserved during unclean shutdown Nebojsa Trpkovic
2010-06-28 19:57 ` tytso [this message]
2010-06-30 5:46 ` Andreas Dilger
2010-06-30 13:31 ` tytso
2010-06-30 21:54 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628195739.GB6094@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=trx.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).