From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] jbd2: Make barrier messages less scary
Date: Tue, 27 Jul 2010 09:58:23 -0400 [thread overview]
Message-ID: <20100727135823.GG18966@thunk.org> (raw)
In-Reply-To: <4C4DE515.5020307@redhat.com>
On Mon, Jul 26, 2010 at 02:42:13PM -0500, Eric Sandeen wrote:
> Saying things like "sync failed" when a device does
> not support barriers makes users slightly more worried than
> they need to be; rather than talking about sync failures,
> let's just state the barrier-based facts.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/fs/jbd2/commit.c b/fs/jbd2/commit.c
> index 75716d3..3d15b28 100644
> --- a/fs/jbd2/commit.c
> +++ b/fs/jbd2/commit.c
> @@ -150,8 +150,8 @@ static int journal_submit_commit_record(journal_t *journal,
> */
> if (ret == -EOPNOTSUPP && barrier_done) {
> printk(KERN_WARNING
> - "JBD: barrier-based sync failed on %s - "
> - "disabling barriers\n", journal->j_devname);
> + "JBD2: Disabling barriers on %s, "
> + "not supported by device\n", journal->j_devname);
> spin_lock(&journal->j_state_lock);
> journal->j_flags &= ~JBD2_BARRIER;
> spin_unlock(&journal->j_state_lock);
> @@ -180,8 +180,8 @@ retry:
> wait_on_buffer(bh);
> if (buffer_eopnotsupp(bh) && (journal->j_flags & JBD2_BARRIER)) {
> printk(KERN_WARNING
> - "JBD2: wait_on_commit_record: sync failed on %s - "
> - "disabling barriers\n", journal->j_devname);
> + "JBD2: %s: barriers no longer supported on %s - "
> + "disabling barriers\n", __func__, journal->j_devname);
Any reason this message has "no longer supported" as opposed to the
"not supported by device" printed above?
- Ted
next prev parent reply other threads:[~2010-07-27 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 19:42 [PATCH] jbd2: Make barrier messages less scary Eric Sandeen
2010-07-27 13:58 ` Ted Ts'o [this message]
2010-07-27 14:21 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727135823.GG18966@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).