linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Chris Frost <chris@frostnet.net>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH V2] mke2fs.8.in: clarify the sign of a block-size constraint.
Date: Fri, 30 Jul 2010 20:40:58 -0400	[thread overview]
Message-ID: <20100731004058.GD31324@thunk.org> (raw)
In-Reply-To: <4C51B37E.4020404@redhat.com>

On Thu, Jul 29, 2010 at 11:59:42AM -0500, Eric Sandeen wrote:
> This bit of the mke2fs manpage is slightly confusing:
> 
> -b block-size
>     Specify the size of blocks in bytes. <snip>
>     If block-size is negative, then mke2fs will use heuristics 
>     to determine the appropriate block size, with the constraint 
>     that the block size will be at least block-size bytes.
> 
> because it sounds like the block size will be at least a negative
> number.  Clarify just what the negative sign means.
> 
> Reported-by: Chris Frost <chris@frostnet.net>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Applied, thanks.

					- Ted

      reply	other threads:[~2010-07-31  0:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-24 22:01 [PATCH] mke2fs.8.in: correct the sign of a block-size constraint Chris Frost
2010-07-25  4:55 ` Eric Sandeen
2010-07-29  4:11   ` Chris Frost
2010-07-29 16:59 ` [PATCH V2] mke2fs.8.in: clarify " Eric Sandeen
2010-07-31  0:40   ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100731004058.GD31324@thunk.org \
    --to=tytso@mit.edu \
    --cc=chris@frostnet.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).