[PATCH] mke2fs.8.in: correct the sign of a block-size constraint.

[PATCH] mke2fs.8.in: correct the sign of a block-size constraint.

[Chris Frost]

Small but technical typo correction.

There may be more preferred mark ups (e.g., no space between the negative
sign and "block-sized") or expressions (e.g., absolute value instead of
negation).


Signed-off-by: Chris Frost <chris@frostnet.net>
---
 misc/mke2fs.8.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
index 45a99f8..05cfe17 100644
--- a/misc/mke2fs.8.in
+++ b/misc/mke2fs.8.in
@@ -177,7 +177,7 @@ is negative, then
 .B mke2fs
 will use heuristics to determine the
 appropriate block size, with the constraint that the block size will be
-at least
+at least \-
 .I block-size
 bytes.  This is useful for certain hardware devices which require that
 the blocksize be a multiple of 2k.
-- 
1.7.0.4

-- 
Chris Frost
http://www.frostnet.net/chris/

Re: [PATCH] mke2fs.8.in: correct the sign of a block-size constraint.

[Eric Sandeen]

Chris Frost wrote:
> Small but technical typo correction.
> 
> There may be more preferred mark ups (e.g., no space between the negative
> sign and "block-sized") or expressions (e.g., absolute value instead of
> negation).

wow I didn't even know that behavior existed.

How about "If block-size is preceded by a negative sign ("-"), then mke2fs 
will use heuristics to determine the appropriate block size, with the 
constraint that the block size will be at least block-size bytes."

-Eric

> 
> Signed-off-by: Chris Frost <chris@frostnet.net>
> ---
>  misc/mke2fs.8.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
> index 45a99f8..05cfe17 100644
> --- a/misc/mke2fs.8.in
> +++ b/misc/mke2fs.8.in
> @@ -177,7 +177,7 @@ is negative, then
>  .B mke2fs
>  will use heuristics to determine the
>  appropriate block size, with the constraint that the block size will be
> -at least
> +at least \-
>  .I block-size
>  bytes.  This is useful for certain hardware devices which require that
>  the blocksize be a multiple of 2k.

Re: [PATCH] mke2fs.8.in: correct the sign of a block-size constraint.

[Chris Frost]

On Sat, Jul 24, 2010 at 11:55:55PM -0500, Eric Sandeen wrote:
> wow I didn't even know that behavior existed.
> 
> How about "If block-size is preceded by a negative sign ("-"), then mke2fs 
> will use heuristics to determine the appropriate block size, with the 
> constraint that the block size will be at least block-size bytes."

I think this is more readable; thanks!

-- 
Chris Frost
http://www.frostnet.net/chris/

[PATCH V2] mke2fs.8.in: clarify the sign of a block-size constraint.

[Eric Sandeen]

This bit of the mke2fs manpage is slightly confusing:

-b block-size
    Specify the size of blocks in bytes. <snip>
    If block-size is negative, then mke2fs will use heuristics 
    to determine the appropriate block size, with the constraint 
    that the block size will be at least block-size bytes.

because it sounds like the block size will be at least a negative
number.  Clarify just what the negative sign means.

Reported-by: Chris Frost <chris@frostnet.net>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/misc/mke2fs.8.in b/misc/mke2fs.8.in
index 45a99f8..b46e7e2 100644
--- a/misc/mke2fs.8.in
+++ b/misc/mke2fs.8.in
@@ -173,7 +173,7 @@ the expected usage of the filesystem (see the
 .B \-T
 option).  If
 .I block-size
-is negative, then
+is preceded by a negative sign ('-'), then
 .B mke2fs
 will use heuristics to determine the
 appropriate block size, with the constraint that the block size will be

Re: [PATCH V2] mke2fs.8.in: clarify the sign of a block-size constraint.

[Ted Ts'o]

On Thu, Jul 29, 2010 at 11:59:42AM -0500, Eric Sandeen wrote:
> This bit of the mke2fs manpage is slightly confusing:
> 
> -b block-size
>     Specify the size of blocks in bytes. <snip>
>     If block-size is negative, then mke2fs will use heuristics 
>     to determine the appropriate block size, with the constraint 
>     that the block size will be at least block-size bytes.
> 
> because it sounds like the block size will be at least a negative
> number.  Clarify just what the negative sign means.
> 
> Reported-by: Chris Frost <chris@frostnet.net>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Applied, thanks.

					- Ted