From: Jan Kara <jack@suse.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, jmoyer@redhat.com,
rwheeler@redhat.com, eshishki@redhat.com, sandeen@redhat.com,
jack@suse.cz, tytso@mit.edu
Subject: Re: [PATCH 2/3] Add batched discard support for ext3
Date: Wed, 4 Aug 2010 16:03:45 +0200 [thread overview]
Message-ID: <20100804140345.GA4139@quack.suse.cz> (raw)
In-Reply-To: <1280929475-12823-2-git-send-email-lczerner@redhat.com>
Hi,
The patch looks good. Just one small thing:
On Wed 04-08-10 15:44:34, Lukas Czerner wrote:
> + gdp = ext3_get_group_desc(sb, group, &gdp_bh);
> + if (!gdp)
> + goto err_out;
> +
> + BUFFER_TRACE(gd_bh, "get_write_access");
^^^^^ gdp_bh
So you can add: Reviewed-by: Jan Kara <jack@suse.cz>
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-08-04 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 13:44 [PATCH 1/3] Add ioctl FITRIM Lukas Czerner
2010-08-04 13:44 ` [PATCH 2/3] Add batched discard support for ext3 Lukas Czerner
2010-08-04 14:03 ` Jan Kara [this message]
2010-08-04 14:32 ` Lukas Czerner
2010-08-04 19:39 ` Andreas Dilger
2010-08-05 14:00 ` Lukas Czerner
2010-08-04 13:44 ` [PATCH 3/3] Add batched discard support for ext4 Lukas Czerner
2010-08-04 14:17 ` Jan Kara
2010-08-04 14:57 ` [PATCH 1/3] Add ioctl FITRIM Dmitry Monakhov
2010-08-04 15:13 ` Lukas Czerner
2010-08-04 15:26 ` Greg Freemyer
2010-08-05 0:28 ` Ted Ts'o
2010-08-05 6:51 ` Dmitry Monakhov
2010-08-05 15:47 ` Andreas Dilger
2010-08-05 7:00 ` Dmitry Monakhov
2010-08-05 8:36 ` Lukas Czerner
-- strict thread matches above, loose matches on Subject: below --
2010-08-10 14:19 [PATCH 0/3 ver. 7] Ext3/Ext4 Batched discard support Lukas Czerner
2010-08-10 14:19 ` [PATCH 2/3] Add batched discard support for ext3 Lukas Czerner
2010-08-06 11:31 [PATCH 0/3] Batched discard support Lukas Czerner
2010-08-06 11:31 ` [PATCH 2/3] Add batched discard support for ext3 Lukas Czerner
2010-07-27 12:41 [PATCH 0/3 v3] Batched discard support for Ext3/Ext4 Lukas Czerner
2010-07-27 12:41 ` [PATCH 2/3] Add batched discard support for ext3 Lukas Czerner
2010-07-27 15:43 ` Jan Kara
2010-07-28 9:13 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804140345.GA4139@quack.suse.cz \
--to=jack@suse.cz \
--cc=eshishki@redhat.com \
--cc=jmoyer@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).