From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 3/4] Add batched discard support for ext4 Date: Wed, 4 Aug 2010 17:59:59 +0200 Message-ID: <20100804155959.GD7037@quack.suse.cz> References: <1280935813-4478-1-git-send-email-lczerner@redhat.com> <1280935813-4478-3-git-send-email-lczerner@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, jmoyer@redhat.com, rwheeler@redhat.com, eshishki@redhat.com, sandeen@redhat.com, jack@suse.cz, tytso@mit.edu, Dmitry Monakhov To: Lukas Czerner Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51002 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380Ab0HDQAa (ORCPT ); Wed, 4 Aug 2010 12:00:30 -0400 Content-Disposition: inline In-Reply-To: <1280935813-4478-3-git-send-email-lczerner@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed 04-08-10 17:30:12, Lukas Czerner wrote: > Walk through each allocation group and trim all free extents. It can be > invoked through TRIM ioctl on the file system. The main idea is to > provide a way to trim the whole file system if needed, since some SSD's > may suffer from performance loss after the whole device was filled (it > does not mean that fs is full!). > > It search fro free extents in each allocation group. When the free > extent is found, blocks are marked as used in the buddy bitmap and then > trimmed. Afterwards these blocks are marked as free in per-group buddy > bitmap. > > Since fstrim is a long operation it is good to have an ability to interrupt > it by a signal. This was added by Dmitry Monakhov. Thanks Dimitry. > > Signed-off-by: Lukas Czerner > Signed-off-by: Dmitry Monakhov Looks good now. So you can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR