[PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used

[PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used

[Christoph Fritz]

Commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 makes variable ts unused
when CONFIG_JBD2_DEBUG is not used. This patch ifdefs it too.

fs/jbd2/transaction.c: In function ‘start_this_handle’:
fs/jbd2/transaction.c:98: warning: unused variable ‘ts’

Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
 fs/jbd2/transaction.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index d95cc9d..745d3b2 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -95,7 +95,9 @@ static int start_this_handle(journal_t *journal, handle_t *handle,
 	int needed;
 	int nblocks = handle->h_buffer_credits;
 	transaction_t *new_transaction = NULL;
+#ifdef CONFIG_JBD2_DEBUG
 	unsigned long ts = jiffies;
+#endif
 
 	if (nblocks > journal->j_max_transaction_buffers) {
 		printk(KERN_ERR "JBD: %s wants too many credits (%d > %d)\n",
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] jbd2: fix warning if CONFIG_JBD2_DEBUG is not used

[Ted Ts'o]

On Wed, Aug 11, 2010 at 03:39:02AM +0200, Christoph Fritz wrote:
> Commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 makes variable ts unused
> when CONFIG_JBD2_DEBUG is not used. This patch ifdefs it too.
> 
> fs/jbd2/transaction.c: In function ‘start_this_handle’:
> fs/jbd2/transaction.c:98: warning: unused variable ‘ts’
> 
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>

I have a patch queued up to fix this already, using an approach
suggested by Linus.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html