linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Vitali Lovich <vlovich@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: question about i_dtime being used as an orphan list pointer
Date: Wed, 25 Aug 2010 16:39:14 -0400	[thread overview]
Message-ID: <20100825203914.GF4453@thunk.org> (raw)
In-Reply-To: <AANLkTi=3hK1RLRJ+2Kt0ju=HEr-LdkO9eX_YxLfp0wea@mail.gmail.com>

On Wed, Aug 25, 2010 at 12:22:22PM -0700, Vitali Lovich wrote:
> So I've run into this problem where the clock was reset into the 1970s
> on my system, causing e2fsck to get confused & think a file I deleted
> actually had an orphan list inode pointer stored in the i_dtime
> instead of the deletion time, causing e2fsck to get all confused &
> return an error code.

Are you worried about solving this problem as a one shot deal, or as a
long-term design issue.  The long-term proper solution is run your
clock so it is correct.  :-)

In the short term, probably the easist thing to do is just run e2fsck
-y and let those inodes get populated into lost+found, and then delete
them by hands afterwards.

For a long-term fix, it probably would make sense to patch ext3/ext4
so that when we delete a file, and the current time is less than
number of inodes, that we set dtime to 0xffffffff.

> Even a value of midnight 2010 corresponds to a limit of only about 1
> billion files (1 262 304 000).  Thus it seems if you delete a file on
> a partition with more than a billion files, it will make e2fsck think
> you've got a corrupt file-system even though you don't.

And if you assuming the smallest possible inode ratio, that's a 4.5TB
file.  If you use the default inode, that's a 18TB.  Ext3 is limited
to 16TB, so that's not even an issue....

	   	    				- Ted

  reply	other threads:[~2010-08-25 20:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 19:22 question about i_dtime being used as an orphan list pointer Vitali Lovich
2010-08-25 20:39 ` Ted Ts'o [this message]
2010-08-25 21:25   ` Vitali Lovich
2010-08-25 22:48     ` Ted Ts'o
2010-08-25 22:51       ` Vitali Lovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100825203914.GF4453@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=vlovich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).