From: Ted Ts'o <tytso@mit.edu>
To: Vitali Lovich <vlovich@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: question about i_dtime being used as an orphan list pointer
Date: Wed, 25 Aug 2010 18:48:30 -0400 [thread overview]
Message-ID: <20100825224830.GK4453@thunk.org> (raw)
In-Reply-To: <AANLkTi=6tfTpDLqiYpvkOwcWZsWRqru9bHOeOdP=ghf0@mail.gmail.com>
On Wed, Aug 25, 2010 at 02:25:37PM -0700, Vitali Lovich wrote:
> > For a long-term fix, it probably would make sense to patch ext3/ext4
> > so that when we delete a file, and the current time is less than
> > number of inodes, that we set dtime to 0xffffffff.
>
> Is the i_dtime actually used at all? Could we just patch it to always
> set that as the i_dtime always? I grepped the source, & no one is
> actually using the i_dtime field.
It's not used by the kernel, but it is used occasionally by people who
are trouble shooting file systems, and want to know when a particular
inode was deleted. So a local hack to always set i_dtime to ~0 would
not be horrible. But something which sets i_dtime to the system time,
unless this would cause confusion with an orphaned inode linked list,
in which case ~0 is used instead, is probably a cleaner fix.
- Ted
next prev parent reply other threads:[~2010-08-25 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 19:22 question about i_dtime being used as an orphan list pointer Vitali Lovich
2010-08-25 20:39 ` Ted Ts'o
2010-08-25 21:25 ` Vitali Lovich
2010-08-25 22:48 ` Ted Ts'o [this message]
2010-08-25 22:51 ` Vitali Lovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825224830.GK4453@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=vlovich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).