From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] mke2fs: make "invalid blocks count" error more clear
Date: Mon, 20 Sep 2010 09:26:31 -0400 [thread overview]
Message-ID: <20100920132631.GF3554@thunk.org> (raw)
In-Reply-To: <4C64402C.3050205@redhat.com>
On Thu, Aug 12, 2010 at 02:40:44PM -0400, Eric Sandeen wrote:
> Mistakes on the commandline can lead to odd error messages:
>
> # mke2fs -t ext4 -E stride=128 stripe-width=512 /dev/sda1
> mke2fs: invalid blocks count - /dev/sda1
>
> Making it a bit more explicit is more obvious:
>
> mke2fs: invalid blocks count '/dev/sda1' on device 'stripe-width=512'
>
> (hint, the mistake was no comma separation for -E)
>
> Reported-by: Adam Huffman <bloch@verdurin.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to the e2fsprogs maint branch, thanks!!
- Ted
prev parent reply other threads:[~2010-09-20 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 18:40 [PATCH] mke2fs: make "invalid blocks count" error more clear Eric Sandeen
2010-09-20 13:26 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920132631.GF3554@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).