From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] don't use ext4_allocation_contexts for tracing
Date: Sat, 9 Oct 2010 19:04:58 -0400 [thread overview]
Message-ID: <20101009230457.GD11237@thunk.org> (raw)
In-Reply-To: <4C6EDCCF.1000104@redhat.com>
On Fri, Aug 20, 2010 at 02:51:43PM -0500, Eric Sandeen wrote:
> Many tracepoints were populating an ext4_allocation_context
> to pass in, but this requires a slab allocation even when
> tracepoints are off. In fact, 4 of 5 of these allocations
> were only for tracing. In addition, we were only using a
> small fraction of the 144 bytes of this structure for this
> purpose.
>
> We can do away with all these alloc/frees of the ac and
> simply pass in the bits we care about, instead.
>
> I tested this by turning on tracing and running through
> xfstests on x86_64. I did not actually do anything with
> the trace output, however.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Added to the patch tree, thanks!
I made a slight change to drop passing in the logical parameter to
trace_ext4_mballoc_discard() and trace_ext4_mballoc_free(), since
passing in 0 all the time doesn't really buy us much. :-)
- Ted
prev parent reply other threads:[~2010-10-09 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 19:51 [PATCH] don't use ext4_allocation_contexts for tracing Eric Sandeen
2010-10-09 23:04 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009230457.GD11237@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).