From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Jiaying Zhang <jiayingz@google.com>
Subject: Re: [PATCH] ext4: queue conversion after adding to inode's completed IO list
Date: Sat, 9 Oct 2010 19:14:51 -0400 [thread overview]
Message-ID: <20101009231451.GE11237@thunk.org> (raw)
In-Reply-To: <4CAE022C.7050504@redhat.com>
On Thu, Oct 07, 2010 at 12:23:56PM -0500, Eric Sandeen wrote:
> On 08/06/2010 02:52 PM, Eric Sandeen wrote:
> > By queuing the io end on the unwritten workqueue before adding it
> > to our inode's list of completed IOs, I think we run the risk
> > of the work getting completed, and the IO freed, before we try
> > to add it to the inode's i_completed_io_list.
> >
> > It should be safe to add it to the inode's list of completed
> > IOs, and -then- queue it for completion, I think.
>
> Ping? would be good to fix this race, this has jiaying's ack too.
Added to the ext4 patch queue, thanks for the ping.
- Ted
prev parent reply other threads:[~2010-10-09 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 19:52 [PATCH] ext4: queue conversion after adding to inode's completed IO list Eric Sandeen
2010-08-06 20:45 ` Jiaying Zhang
2010-10-07 17:23 ` Eric Sandeen
2010-10-09 23:14 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009231451.GE11237@thunk.org \
--to=tytso@mit.edu \
--cc=jiayingz@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).