Re: [PATCH 11/22] ext3: use little endian bitops

[Jan Kara <jack@suse.cz>]

On Fri 15-10-10 18:46:10, Akinobu Mita wrote:
> As a preparation for removing ext2 non-atomic bit operations from
> asm/bitops.h. This converts ext2 non-atomic bit operations to
> little endian bit operations.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: linux-ext4@vger.kernel.org
  Acked-by: Jan Kara <jack@suse.cz>

								Honza
> ---
>  include/linux/ext3_fs.h |   15 ++++++++++-----
>  1 files changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h
> index 6ce1bca..34ef455 100644
> --- a/include/linux/ext3_fs.h
> +++ b/include/linux/ext3_fs.h
> @@ -418,13 +418,18 @@ struct ext3_inode {
>  #define EXT2_MOUNT_DATA_FLAGS		EXT3_MOUNT_DATA_FLAGS
>  #endif
>  
> -#define ext3_set_bit			ext2_set_bit
> +#define ext3_set_bit(nr, addr)	\
> +	__test_and_set_le_bit((nr), (unsigned long *)(addr))
>  #define ext3_set_bit_atomic		ext2_set_bit_atomic
> -#define ext3_clear_bit			ext2_clear_bit
> +#define ext3_clear_bit(nr, addr)	\
> +	__test_and_clear_le_bit((nr), (unsigned long *)(addr))
>  #define ext3_clear_bit_atomic		ext2_clear_bit_atomic
> -#define ext3_test_bit			ext2_test_bit
> -#define ext3_find_first_zero_bit	ext2_find_first_zero_bit
> -#define ext3_find_next_zero_bit		ext2_find_next_zero_bit
> +#define ext3_test_bit(nr, addr)	\
> +	test_le_bit((nr), (unsigned long *)(addr))
> +#define ext3_find_first_zero_bit(addr, size)	\
> +	find_first_zero_le_bit((unsigned long *)(addr), (size))
> +#define ext3_find_next_zero_bit(addr, size, off)	\
> +	find_next_zero_le_bit((unsigned long *)(addr), (size), (off))
>  
>  /*
>   * Maximal mount counts between two filesystem checks
> -- 
> 1.7.1.231.gd0b16
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR