* [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()
@ 2010-10-15 11:03 Namhyung Kim
2010-10-18 10:54 ` Jan Kara
2010-10-18 14:22 ` Eric Sandeen
0 siblings, 2 replies; 4+ messages in thread
From: Namhyung Kim @ 2010-10-15 11:03 UTC (permalink / raw)
To: Jan Kara, Andrew Morton, Andreas Dilger; +Cc: linux-ext4, linux-kernel
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
fs/ext3/inode.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 5e0faf4..90a9c3d 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
*/
} else {
/* Shared branch grows from an indirect block */
- BUFFER_TRACE(partial->bh, "get_write_access");
ext3_free_branches(handle, inode, partial->bh,
partial->p,
partial->p+1, (chain+n-1) - partial);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()
2010-10-15 11:03 [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate() Namhyung Kim
@ 2010-10-18 10:54 ` Jan Kara
2010-10-18 14:22 ` Eric Sandeen
1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2010-10-18 10:54 UTC (permalink / raw)
To: Namhyung Kim
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4, linux-kernel
On Fri 15-10-10 20:03:02, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Thanks. Merged.
Honza
> ---
> fs/ext3/inode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 5e0faf4..90a9c3d 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
> */
> } else {
> /* Shared branch grows from an indirect block */
> - BUFFER_TRACE(partial->bh, "get_write_access");
> ext3_free_branches(handle, inode, partial->bh,
> partial->p,
> partial->p+1, (chain+n-1) - partial);
> --
> 1.7.0.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()
2010-10-15 11:03 [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate() Namhyung Kim
2010-10-18 10:54 ` Jan Kara
@ 2010-10-18 14:22 ` Eric Sandeen
2010-10-18 14:53 ` Namhyung Kim
1 sibling, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2010-10-18 14:22 UTC (permalink / raw)
To: Namhyung Kim
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4, linux-kernel
Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> fs/ext3/inode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 5e0faf4..90a9c3d 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
> */
> } else {
> /* Shared branch grows from an indirect block */
> - BUFFER_TRACE(partial->bh, "get_write_access");
> ext3_free_branches(handle, inode, partial->bh,
> partial->p,
> partial->p+1, (chain+n-1) - partial);
As long as you're doing these cleanups, you may as well eyeball ext4
to see whether the same issues exist; in the case above, it does, and the
exact same patch (modulo ext3/ext4 changes) applies.
No real point in getting ext3 fixed up and leaving ext4 behind...
Thanks,
-Eric
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()
2010-10-18 14:22 ` Eric Sandeen
@ 2010-10-18 14:53 ` Namhyung Kim
0 siblings, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2010-10-18 14:53 UTC (permalink / raw)
To: Eric Sandeen
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4, linux-kernel
2010-10-18 (월), 09:22 -0500, Eric Sandeen:
> As long as you're doing these cleanups, you may as well eyeball ext4
> to see whether the same issues exist; in the case above, it does, and the
> exact same patch (modulo ext3/ext4 changes) applies.
>
> No real point in getting ext3 fixed up and leaving ext4 behind...
>
My plan was sending those patches in a batch after reading ext3 at all.
But it seems to take some time, so now I think that it'd be better to
send them in a small series. I'll prepare it for ext4 (and ext2 too if
you want, Jan) soon. Thanks.
--
Regards,
Namhyung Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-18 14:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 11:03 [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate() Namhyung Kim
2010-10-18 10:54 ` Jan Kara
2010-10-18 14:22 ` Eric Sandeen
2010-10-18 14:53 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).