From: Jan Kara <jack@suse.cz>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext3: Fix debug messages in ext3_group_extend()
Date: Mon, 18 Oct 2010 12:57:28 +0200 [thread overview]
Message-ID: <20101018105728.GK3826@quack.suse.cz> (raw)
In-Reply-To: <1287245483-3557-1-git-send-email-namhyung@gmail.com>
On Sun 17-10-10 01:11:23, Namhyung Kim wrote:
> Fix a typo, break long lines and use E3FSBLK on ext3_fsblk_t.
Thanks. Merged.
Honza
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
> fs/ext3/resize.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c
> index 0ccd7b1..e746d30 100644
> --- a/fs/ext3/resize.c
> +++ b/fs/ext3/resize.c
> @@ -977,7 +977,8 @@ int ext3_group_extend(struct super_block *sb, struct ext3_super_block *es,
> o_blocks_count = le32_to_cpu(es->s_blocks_count);
>
> if (test_opt(sb, DEBUG))
> - printk(KERN_DEBUG "EXT3-fs: extending last group from "E3FSBLK" uto "E3FSBLK" blocks\n",
> + printk(KERN_DEBUG "EXT3-fs: extending last group from "E3FSBLK
> + " upto "E3FSBLK" blocks\n",
> o_blocks_count, n_blocks_count);
>
> if (n_blocks_count == 0 || n_blocks_count == o_blocks_count)
> @@ -985,7 +986,7 @@ int ext3_group_extend(struct super_block *sb, struct ext3_super_block *es,
>
> if (n_blocks_count > (sector_t)(~0ULL) >> (sb->s_blocksize_bits - 9)) {
> printk(KERN_ERR "EXT3-fs: filesystem on %s:"
> - " too large to resize to %lu blocks safely\n",
> + " too large to resize to "E3FSBLK" blocks safely\n",
> sb->s_id, n_blocks_count);
> if (sizeof(sector_t) < 8)
> ext3_warning(sb, __func__,
> @@ -1065,11 +1066,11 @@ int ext3_group_extend(struct super_block *sb, struct ext3_super_block *es,
> es->s_blocks_count = cpu_to_le32(o_blocks_count + add);
> ext3_journal_dirty_metadata(handle, EXT3_SB(sb)->s_sbh);
> mutex_unlock(&EXT3_SB(sb)->s_resize_lock);
> - ext3_debug("freeing blocks %lu through "E3FSBLK"\n", o_blocks_count,
> - o_blocks_count + add);
> + ext3_debug("freeing blocks "E3FSBLK" through "E3FSBLK"\n",
> + o_blocks_count, o_blocks_count + add);
> ext3_free_blocks_sb(handle, sb, o_blocks_count, add, &freed_blocks);
> - ext3_debug("freed blocks "E3FSBLK" through "E3FSBLK"\n", o_blocks_count,
> - o_blocks_count + add);
> + ext3_debug("freed blocks "E3FSBLK" through "E3FSBLK"\n",
> + o_blocks_count, o_blocks_count + add);
> if ((err = ext3_journal_stop(handle)))
> goto exit_put;
> if (test_opt(sb, DEBUG))
> --
> 1.7.0.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-10-18 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 16:11 [PATCH] ext3: Fix debug messages in ext3_group_extend() Namhyung Kim
2010-10-18 10:57 ` Jan Kara [this message]
2010-10-18 14:23 ` Eric Sandeen
2010-10-18 14:50 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018105728.GK3826@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).