From: Ted Ts'o <tytso@mit.edu>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: What am I doing wrong? submit_bio() suddenly stops working...
Date: Sat, 23 Oct 2010 10:48:36 -0400 [thread overview]
Message-ID: <20101023144836.GA24650@thunk.org> (raw)
In-Reply-To: <4CC13B09.6030104@kernel.dk>
On Fri, Oct 22, 2010 at 09:19:37AM +0200, Jens Axboe wrote:
>
> In my experience, use-after-free bugs are best caught using the
> allocator poisoning along with lock checking. I guess that didn't
> trigger for you?
No, I tried adding slab_debug=FP, but the structure got reused too
quickly. And I've always had lock checking enabled.
> Out of curiousity, what was the exact bug?
To be honest, I don't know why it was causing the problem. I had a
if (test_bit(BIO_UPTODATE, &bio->bi_flags))
error = 0;
After the bio_put, which was clearly wrong, so I fixed it. But
test_bit is a read-only instruction, and if error should have been
zero since I'm testing using kvm and there haven't been any errors.
(I need to test to make sure my error handling paths work correctly;
later).
But it's now working, and at this point, given that I have something
that works, although I'm curious what was causing the mysterious
failures, I may be willing to just let it be a mystery...
- Ted
prev parent reply other threads:[~2010-10-23 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 2:00 What am I doing wrong? submit_bio() suddenly stops working Theodore Ts'o
2010-10-21 6:59 ` Jens Axboe
2010-10-21 16:55 ` Ted Ts'o
2010-10-21 17:41 ` Boaz Harrosh
2010-10-21 18:07 ` Jens Axboe
2010-10-22 13:04 ` Peter Zijlstra
2010-10-22 14:08 ` Jens Axboe
2010-10-21 18:14 ` Ted Ts'o
2010-10-21 18:21 ` Jens Axboe
2010-10-21 17:46 ` Jens Axboe
2010-10-21 21:29 ` Ted Ts'o
2010-10-22 3:34 ` Ted Ts'o
2010-10-22 7:19 ` Jens Axboe
2010-10-23 14:48 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023144836.GA24650@thunk.org \
--to=tytso@mit.edu \
--cc=axboe@kernel.dk \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).