From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: -tip: origin tree build failure (was: [GIT PULL] ext4 update for 2.6.37)
Date: Thu, 28 Oct 2010 19:17:01 +0200 [thread overview]
Message-ID: <20101028171701.GA18368@elte.hu> (raw)
In-Reply-To: <AANLkTin62vAwJxcsrFk6Yn7Q6tzr-D=EmKKwPazuAJ11@mail.gmail.com>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Oct 28, 2010 at 9:38 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > Point taken in any case, i'll read your edited changelog and will change the
> > template accordingly.
> >
> > Would this:
> >
> > Upstream commit 5dabfc7 ("ext4: rename {exit,init}_ext4_*() to
> > ext4_{exit,init}_*()"), breaks the build on all[yes/mod]config with
> > CONFIG_EXT4_FS_XATTR disabled:
> >
> > ...
> >
> > have been better?
>
> Yes. Except for the kernel the default git commit abbreviation is borderline too
> short. Seven hex-chars can easily alias with a few more pulls from me: git will
> not give aliases at the time it gives a shorthand, but a month or two later the
> abbreviated commit may no longer be unique.
>
> So I suggest using --abbrev=12 or similar.
ok. A helper script i use does this:
git log --pretty=format:"%h: %s" $@
I have added --abbrev=12. Might make sense to lengthen the %h default in upstream
Git as well?
> What I ended up writing your commit as was this:
>
> ext4: fix compile with CONFIG_EXT4_FS_XATTR disabled
>
> Commit 5dabfc78dced ("ext4: rename {exit,init}_ext4_*() to
> ext4_{exit,init}_*()") causes
>
> fs/ext4/super.c:4776: error: implicit declaration of function ‘ext4_init_xattr’
>
> when CONFIG_EXT4_FS_XATTR is disabled.
>
> It renamed init_ext4_xattr to ext4_init_xattr but forgot to update the
> dummy definition in fs/ext4/xattr.h.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Acked-by: "Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>
> but that's just me.
Ok, this indeed is much nicer to read.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-28 17:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 4:52 [GIT PULL] ext4 update for 2.6.37 Theodore Ts'o
2010-10-28 7:50 ` Markus Trippelsdorf
2010-10-28 7:56 ` -tip: origin tree build failure (was: [GIT PULL] ext4 update for 2.6.37) Ingo Molnar
2010-10-28 12:12 ` Theodore Tso
2010-10-28 16:30 ` Linus Torvalds
2010-10-28 16:38 ` Ingo Molnar
2010-10-28 16:55 ` Ted Ts'o
2010-10-28 17:00 ` Linus Torvalds
2010-10-28 17:17 ` Ingo Molnar [this message]
2010-10-28 21:39 ` -tip: origin tree build failure Junio C Hamano
2010-10-28 21:50 ` Linus Torvalds
2010-11-01 16:34 ` ext3 patches related to uninitialized memory references Roman Borisov
-- strict thread matches above, loose matches on Subject: below --
2010-10-28 14:39 -tip: origin tree build failure (was: [GIT PULL] ext4 update for 2.6.37) Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028171701.GA18368@elte.hu \
--to=mingo@elte.hu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).