From: Ted Ts'o <tytso@mit.edu>
To: sedat.dilek@gmail.com
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org, sfr@canb.auug.org.au,
Arnd Bergmann <arnd@arndb.de>,
Avinash Kurup <kurup.avinash@gmail.com>
Subject: Re: [next-20101038] Call trace in ext4
Date: Thu, 28 Oct 2010 16:05:48 -0400 [thread overview]
Message-ID: <20101028200548.GC28126@thunk.org> (raw)
In-Reply-To: <AANLkTimHJe9bA-X+JWkspgjb4AZkkgbEFWQiwzO-gx-h@mail.gmail.com>
On Thu, Oct 28, 2010 at 09:54:23PM +0200, Sedat Dilek wrote:
>
> Hm, unfortunately NO (see logs).
>
> I have compiled via M=fs/ext4 in an already compiled build-tree with
> these 3 patches.
Ok, stupid question. You did make sure the new ext4 module was
loaded, right?
> [ 100.884524] ------------[ cut here ]------------
> [ 100.884718] kernel BUG at /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/ext4/inode.c:2721!
OK, so after the patch, line 2721: changed from page_buffers() to:
if (!page_has_buffers(page))
page_has_buffers() expands to:
#define page_has_buffers(page) PagePrivate(page)
which expands to test_bit() call to see if PG_private1 is set in
page->flags. There is no BUG_ON anywhere there as far as I can tell.
Line 2721 in the older kernel was page_has_buffers() which does have a
BUG_ON check.
- Ted
next prev parent reply other threads:[~2010-10-28 20:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 10:05 [next-20101038] Call trace in ext4 Sedat Dilek
2010-10-28 10:34 ` [next-20101028] " Sedat Dilek
2010-10-28 15:08 ` Sedat Dilek
2010-10-28 15:27 ` Ted Ts'o
2010-10-28 17:52 ` [next-20101038] " Markus Trippelsdorf
2010-10-28 18:01 ` Ted Ts'o
2010-10-28 18:16 ` Eric Sandeen
2010-10-28 19:32 ` Ted Ts'o
2010-10-28 19:36 ` Eric Sandeen
2010-10-28 19:54 ` Ted Ts'o
2010-10-28 19:54 ` Sedat Dilek
2010-10-28 20:05 ` Ted Ts'o [this message]
2010-10-28 20:15 ` Sedat Dilek
2010-10-28 20:37 ` Ted Ts'o
2010-10-28 21:02 ` Sedat Dilek
2010-10-28 21:06 ` Ted Ts'o
2010-10-28 21:17 ` Sedat Dilek
2010-10-28 18:20 ` Sedat Dilek
2010-10-28 18:34 ` Sedat Dilek
2010-10-28 18:55 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028200548.GC28126@thunk.org \
--to=tytso@mit.edu \
--cc=arnd@arndb.de \
--cc=kurup.avinash@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).