* [PATCH] ext4: do not get s_umount sem on ext4_quota_off
@ 2010-10-28 8:47 Dmitry Monakhov
2010-11-03 19:51 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Monakhov @ 2010-10-28 8:47 UTC (permalink / raw)
To: linux-ext4
It must be already acquired by caller. Fix lock_dep complain.
Signed-off-by: Dmitry Monakhov <dmonakhov@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e59eb37..062d1bc 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4107,12 +4107,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
static int ext4_quota_off(struct super_block *sb, int type)
{
- /* Force all delayed allocation blocks to be allocated */
- if (test_opt(sb, DELALLOC)) {
- down_read(&sb->s_umount);
+ /* Force all delayed allocation blocks to be allocated.
+ * Caller already holds s_umount sem */
+ if (test_opt(sb, DELALLOC))
sync_filesystem(sb);
- up_read(&sb->s_umount);
- }
return dquot_quota_off(sb, type);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: do not get s_umount sem on ext4_quota_off
2010-10-28 8:47 [PATCH] ext4: do not get s_umount sem on ext4_quota_off Dmitry Monakhov
@ 2010-11-03 19:51 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-11-03 19:51 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-ext4
On Thu, Oct 28, 2010 at 12:47:19PM +0400, Dmitry Monakhov wrote:
>
> It must be already acquired by caller. Fix lock_dep complain.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@gmail.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Added to the patch queue, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-03 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 8:47 [PATCH] ext4: do not get s_umount sem on ext4_quota_off Dmitry Monakhov
2010-11-03 19:51 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).