From: Dan Carpenter <error27@gmail.com>
To: "潘卫平(Peter Pan)" <wppan@redflag-linux.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4:memset is needless in ext4_ext_remove_space()
Date: Mon, 8 Nov 2010 06:37:52 +0200 [thread overview]
Message-ID: <20101108043752.GB5563@bicker> (raw)
In-Reply-To: <4CD75033.7080902@redflag-linux.com>
On Mon, Nov 08, 2010 at 09:19:47AM +0800, "潘卫平(Peter Pan)" wrote:
>
> memset is needless because path is allocated by kzalloc.
>
This is inside a loop and sometimes we do i++ and sometimes i--. Are
you absolutely positive that path + i isn't initialized?
I haven't followed this code through all the way but my instinct is
that the memset is there for a reason.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-08 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 1:19 [PATCH] ext4:memset is needless in ext4_ext_remove_space() "潘卫平(Peter Pan)"
2010-11-08 4:37 ` Dan Carpenter [this message]
2010-11-08 6:24 ` "Peter Pan(潘卫平)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108043752.GB5563@bicker \
--to=error27@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wppan@redflag-linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).