linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Lukas Czerner <lczerner@redhat.com>,
	Eric Sandeen <sandeen@redhat.com>,
	"Patrick J. LoPresti" <lopresti@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	Mingming Cao <mcao@us.ibm.com>
Subject: [PATCH] ext3: Return error code from generic_check_addressable
Date: Tue, 16 Nov 2010 14:57:44 -0800	[thread overview]
Message-ID: <20101116225744.GD18195@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1011161351230.5515@dhcp-lab-213.englab.brq.redhat.com>

ext3: Return error code from generic_check_accessible

ext3_fill_super should return the error code that generic_check_accessible
returns when an error condition occurs.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---

 fs/ext3/super.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 2fedaf8..960629b 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1842,13 +1842,15 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
 		goto failed_mount;
 	}
 
-	if (generic_check_addressable(sb->s_blocksize_bits,
-				      le32_to_cpu(es->s_blocks_count))) {
+	err = generic_check_addressable(sb->s_blocksize_bits,
+					le32_to_cpu(es->s_blocks_count));
+	if (err) {
 		ext3_msg(sb, KERN_ERR,
 			"error: filesystem is too large to mount safely");
 		if (sizeof(sector_t) < 8)
 			ext3_msg(sb, KERN_ERR,
 				"error: CONFIG_LBDAF not enabled");
+		ret = err;
 		goto failed_mount;
 	}
 

  parent reply	other threads:[~2010-11-16 22:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 21:48 [PATCH] ext4: ext4_fill_super shouldn't return 0 on corruption Darrick J. Wong
2010-11-15 21:55 ` Eric Sandeen
2010-11-15 23:03   ` [PATCH v2] " Darrick J. Wong
2010-11-16 12:56     ` Lukas Czerner
2010-11-16 17:43       ` Eric Sandeen
2010-11-16 22:55       ` Darrick J. Wong
2010-11-18  8:42         ` Lukas Czerner
2010-11-19 14:59         ` Ted Ts'o
2010-11-16 22:57       ` Darrick J. Wong [this message]
2010-11-18  8:52         ` [PATCH] ext3: Return error code from generic_check_addressable Lukas Czerner
2010-11-22 18:27           ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116225744.GD18195@tux1.beaverton.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lopresti@gmail.com \
    --cc=mcao@us.ibm.com \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).