From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>,
Lukas Czerner <lczerner@redhat.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-ja
Subject: Re: [patch] ext4: missing unlock in ext4_clear_request_list()
Date: Wed, 17 Nov 2010 14:01:25 -0500 [thread overview]
Message-ID: <20101117190125.GJ3290@thunk.org> (raw)
In-Reply-To: <20101117050732.GB31724@bicker>
On Wed, Nov 17, 2010 at 08:07:32AM +0300, Dan Carpenter wrote:
> If the the li_request_list was empty then it returned with the lock
> held. Instead of adding a "goto unlock" I just removed that special
> case and let it go past the empty list_for_each_safe().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice catch. Thanks, I've grabbed this and put it into the ext4 patch
queue and will be pushing it to Linus ASAP.
- Ted
prev parent reply other threads:[~2010-11-17 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 5:07 [patch] ext4: missing unlock in ext4_clear_request_list() Dan Carpenter
2010-11-17 19:01 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117190125.GJ3290@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=error27@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).