* [patch] ext4: missing unlock in ext4_clear_request_list()
@ 2010-11-17 5:07 Dan Carpenter
2010-11-17 19:01 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-11-17 5:07 UTC (permalink / raw)
To: Theodore Ts'o, Lukas Czerner
Cc: Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors
If the the li_request_list was empty then it returned with the lock
held. Instead of adding a "goto unlock" I just removed that special
case and let it go past the empty list_for_each_safe().
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
This is a static checker patch.
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 61182fe..ef09d14 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2799,9 +2799,6 @@ static void ext4_clear_request_list(void)
struct ext4_li_request *elr;
mutex_lock(&ext4_li_info->li_list_mtx);
- if (list_empty(&ext4_li_info->li_request_list))
- return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ext4: missing unlock in ext4_clear_request_list()
2010-11-17 5:07 [patch] ext4: missing unlock in ext4_clear_request_list() Dan Carpenter
@ 2010-11-17 19:01 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-11-17 19:01 UTC (permalink / raw)
To: Dan Carpenter, Lukas Czerner, Andreas Dilger, linux-ext4,
linux-kernel, kernel-ja
On Wed, Nov 17, 2010 at 08:07:32AM +0300, Dan Carpenter wrote:
> If the the li_request_list was empty then it returned with the lock
> held. Instead of adding a "goto unlock" I just removed that special
> case and let it go past the empty list_for_each_safe().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Nice catch. Thanks, I've grabbed this and put it into the ext4 patch
queue and will be pushing it to Linus ASAP.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-17 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17 5:07 [patch] ext4: missing unlock in ext4_clear_request_list() Dan Carpenter
2010-11-17 19:01 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).