From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ted Ts'o <tytso@mit.edu>
Cc: Nick Piggin <npiggin@kernel.dk>,
Eric Sandeen <sandeen@redhat.com>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [patch] fix up lock order reversal in writeback
Date: Thu, 18 Nov 2010 18:53:50 +0000 [thread overview]
Message-ID: <20101118185350.GD19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20101118030613.GQ3290@thunk.org>
On Wed, Nov 17, 2010 at 10:06:13PM -0500, Ted Ts'o wrote:
> This makes sense to me as well.
>
> Acked-by: "Theodore Ts'o" <tytso@mit.edu>
>
> So how do we want to send this patch to Linus? It's a writeback
> change, so through some mm tree? Or it lives in fs/fs-writeback.c
> (which I always thought was weird; why is it not in mm/?), so maybe
> through the VFS tree, even though I don't think Al would really care
> about this patch.
As in "don't really like", TBH. I'll take it (with saner commit message
and comment in the source), but I really wonder if we are just asking for
more trouble down the road.
Specifically, I *really* want to see locking rules for that sucker
spelled out. What can be held by caller?
next prev parent reply other threads:[~2010-11-18 18:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 11:00 [patch] fix up lock order reversal in writeback Nick Piggin
2010-11-16 13:01 ` Jan Kara
2010-11-17 4:30 ` Eric Sandeen
2010-11-17 4:38 ` Nick Piggin
2010-11-17 5:05 ` Eric Sandeen
2010-11-17 6:10 ` Nick Piggin
2010-11-18 3:06 ` Ted Ts'o
2010-11-18 3:29 ` Andrew Morton
2010-11-18 6:00 ` Nick Piggin
2010-11-18 6:28 ` Andrew Morton
2010-11-18 8:18 ` Nick Piggin
2010-11-18 10:51 ` Theodore Tso
2010-11-18 17:58 ` Andrew Morton
2010-11-19 5:10 ` Nick Piggin
2010-11-19 12:07 ` Theodore Tso
2010-11-18 14:55 ` Eric Sandeen
2010-11-18 17:10 ` Andrew Morton
2010-11-18 18:04 ` Eric Sandeen
2010-11-18 18:24 ` Eric Sandeen
2010-11-18 18:39 ` Chris Mason
2010-11-18 18:36 ` Andrew Morton
2010-11-18 18:51 ` Chris Mason
2010-11-18 20:22 ` Andrew Morton
2010-11-18 20:36 ` Chris Mason
2010-11-18 19:02 ` Eric Sandeen
2010-11-18 20:17 ` Andrew Morton
2010-11-18 18:33 ` Chris Mason
2010-11-18 23:58 ` Jan Kara
2010-11-19 0:45 ` Jan Kara
2010-11-19 5:16 ` Nick Piggin
2010-11-22 18:16 ` Jan Kara
2010-11-23 8:07 ` Nick Piggin
2010-11-23 13:32 ` Jan Kara
2010-11-23 8:15 ` Nick Piggin
2010-11-18 18:53 ` Al Viro [this message]
2010-11-18 3:18 ` Eric Sandeen
2010-11-22 23:43 ` Andrew Morton
2010-11-16 20:32 ` Andrew Morton
2010-11-17 3:56 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118185350.GD19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).