From: Joerg Roedel <joro@8bytes.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix 'return 0' for error case in ext4_fill_super
Date: Thu, 18 Nov 2010 23:38:05 +0100 [thread overview]
Message-ID: <20101118223805.GA15575@8bytes.org> (raw)
In-Reply-To: <20101118222157.GE18195@tux1.beaverton.ibm.com>
On Thu, Nov 18, 2010 at 02:21:57PM -0800, Darrick J. Wong wrote:
> On Thu, Nov 18, 2010 at 10:47:12PM +0100, Joerg Roedel wrote:
> > This patch fixes the issue by using the 'err' variable instead of 'ret'
> > for that function-call like it is done in for all other function-calls
> > in ext4_fill_super too.
> > If have seen this issue on 2.6.36 too, so this patch may be -stable
> > material as well.
>
> Lukas and I have been trying to fix this bug for a couple of days now, and he
> actually sent off an identical patch this morning:
> http://www.spinics.net/lists/linux-ext4/msg21743.html
>
> (I also sent off a similar cleanup of the ext3 counterpart.)
>
> But, thanks for pointing this out! :)
Oh ok, good to know. I ran into this issue today when I installed a new
kernel on that machine and the 'update-grub' command gave me an ooops.
Good to know it will be fixed soon :)
Joerg
prev parent reply other threads:[~2010-11-18 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 21:47 [PATCH] ext4: Fix 'return 0' for error case in ext4_fill_super Joerg Roedel
2010-11-18 22:21 ` Darrick J. Wong
2010-11-18 22:38 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118223805.GA15575@8bytes.org \
--to=joro@8bytes.org \
--cc=adilger.kernel@dilger.ca \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).