From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: sandeen@redhat.com, adilger@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [4/6] mke2fs: Deprecate -K option, introduce discard/nodiscard
Date: Tue, 23 Nov 2010 10:17:30 -0500 [thread overview]
Message-ID: <20101123151730.GD32759@thunk.org> (raw)
In-Reply-To: <1290087521-9123-5-git-send-email-lczerner@redhat.com>
On Thu, Nov 18, 2010 at 03:38:39AM -0000, Lukas Czerner wrote:
> It would be nice to have consistent "discard" options in every system
> tool (mount, fsck, mkfs) taking advantage of discards. Also "discard"
> and "nodiscard" is more descriptive instead of just "-K" and can be
> easily defaulted and it is something we can not do with "-K".
>
> With this commit you need to specify extended option like this:
>
> ./mke2fs -T <fstype> -E nodiscard <device>
>
> in order make a filesystem without discarding the device first. And
>
> ./mke2fs -T <fstype> -E discard <device>
>
> respectively.
>
> -K option is with this commit deprecated and should not be used anymore.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied to the maint branch of e2fsprogs, so it will make 1.41.13.
- Ted
next prev parent reply other threads:[~2010-11-23 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 13:38 [PATCH 0/6 v2] e2fsprogs: Using discard in e2fsprogs tools Lukas Czerner
2010-11-18 13:38 ` [PATCH 1/6] e2fsprogs: Add discard function into struct_io_manager Lukas Czerner
2010-11-23 14:54 ` [1/6] " Ted Ts'o
2010-12-02 8:34 ` Lukas Czerner
2010-11-18 13:38 ` [PATCH 2/6] e2fsprogs: Add CHANNEL_FLAGS_DISCARD_ZEROES flag for io_manager Lukas Czerner
2010-11-23 14:55 ` [2/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 3/6] e2fsck: Discard free data and inode blocks Lukas Czerner
2010-11-23 15:17 ` [3/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 4/6] mke2fs: Deprecate -K option, introduce discard/nodiscard Lukas Czerner
2010-11-23 15:17 ` Ted Ts'o [this message]
2010-11-18 13:38 ` [PATCH 5/6] mke2fs: Use unix_discard() for discards Lukas Czerner
2010-11-23 15:18 ` [5/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 6/6] mke2fs: Add discard option into mke2fs.conf Lukas Czerner
2010-11-23 15:18 ` [6/6] " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123151730.GD32759@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).